Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Allows for SSH GitHub Repo" #8157

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Revert "Allows for SSH GitHub Repo" #8157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/javascript/components/ansible-repository-form/ansible-repository-form.schema.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,11 @@ function createSchema(repositoryId) {
type: validatorTypes.REQUIRED,
message: __('Required'),
},
{
type: validatorTypes.URL,
message:
__('URL must include a protocol (http://, https:// or file://) or be a valid SSH path (user@server:path or ssh://user@address:port/path)'),
},
],
},
{
Expand Down
25 changes: 0 additions & 25 deletions app/javascript/components/ansible-repository-form/helpers.jsx
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions app/javascript/components/ansible-repository-form/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import { Loading } from 'carbon-components-react';
import createSchema from './ansible-repository-form.schema';
import miqRedirectBack from '../../helpers/miq-redirect-back';
import { API } from '../../http_api';
import { urlValidation } from './helpers';

const AnsibleRepositoryForm = ({ repositoryId }) => {
const [{
Expand Down Expand Up @@ -112,7 +111,6 @@ const AnsibleRepositoryForm = ({ repositoryId }) => {
onSubmit={onSubmit}
onCancel={onCancel}
canSubmit={false}
validate={urlValidation}
/>
);
};
Expand Down
83 changes: 0 additions & 83 deletions app/javascript/spec/ansible-repository-form/helpers.spec.js
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@
"d3-7.0.0": "npm:d3@^7.0.0",
"eonasdan-bootstrap-datetimepicker": "~4.17.47",
"es6-shim": "~0.35.3",
"git-url-parse": "^11.6.0",
"history": "^4.7.2",
"jquery": "~2.2.4",
"jquery-ui": "~1.13.0",
Expand Down
104 changes: 1 addition & 103 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8127,13 +8127,6 @@ __metadata:
languageName: node
linkType: hard

"filter-obj@npm:^1.1.0":
version: 1.1.0
resolution: "filter-obj@npm:1.1.0"
checksum: cf2104a7c45ff48e7f505b78a3991c8f7f30f28bd8106ef582721f321f1c6277f7751aacd5d83026cb079d9d5091082f588d14a72e7c5d720ece79118fa61e10
languageName: node
linkType: hard

"final-form-arrays@npm:^3.0.2":
version: 3.0.2
resolution: "final-form-arrays@npm:3.0.2"
Expand Down Expand Up @@ -8665,25 +8658,6 @@ fsevents@^1.2.7:
languageName: node
linkType: hard

"git-up@npm:^4.0.0":
version: 4.0.5
resolution: "git-up@npm:4.0.5"
dependencies:
is-ssh: ^1.3.0
parse-url: ^6.0.0
checksum: dd8f39a115ec0523b7da369cd4c6dc94a9b11fcc652e6fc9d011a93c287e27cc34e1d1c89cff8864f9ab11a1b2bea49786951d8eb3f1e5babd351afcc63f6135
languageName: node
linkType: hard

"git-url-parse@npm:^11.6.0":
version: 11.6.0
resolution: "git-url-parse@npm:11.6.0"
dependencies:
git-up: ^4.0.0
checksum: 18a7d0bbac76c55fe8a501d4bd4c6b5f5528883a4dadcfce1152b4902e3e5831df8e97f36ea3f564de633e9ab44d9ab09bb2f319e41af1b6e4f627af139d35d5
languageName: node
linkType: hard

"glob-parent@npm:^3.1.0":
version: 3.1.0
resolution: "glob-parent@npm:3.1.0"
Expand Down Expand Up @@ -10025,15 +9999,6 @@ fsevents@^1.2.7:
languageName: node
linkType: hard

"is-ssh@npm:^1.3.0":
version: 1.3.3
resolution: "is-ssh@npm:1.3.3"
dependencies:
protocols: ^1.1.0
checksum: 7a751facad3c61abf080eefe4f5df488d37f690ac2b130a8012001ecee4d7991306561bcb25896894d19268ea0512b20497f243e74d21c5901187a8f55f1c08c
languageName: node
linkType: hard

"is-stream@npm:^1.1.0":
version: 1.1.0
resolution: "is-stream@npm:1.1.0"
Expand Down Expand Up @@ -11810,7 +11775,6 @@ fsevents@^1.2.7:
eslint-plugin-react: ~7.21.4
fetch-mock: ^7.2.5
file-loader: ~6.0.0
git-url-parse: ^11.6.0
glob: ~7.1.1
history: ^4.7.2
identity-obj-proxy: ^3.0.0
Expand Down Expand Up @@ -12724,7 +12688,7 @@ fsevents@^1.2.7:
languageName: node
linkType: hard

"normalize-url@npm:^6.0.1, normalize-url@npm:^6.1.0":
"normalize-url@npm:^6.0.1":
version: 6.1.0
resolution: "normalize-url@npm:6.1.0"
checksum: 4a4944631173e7d521d6b80e4c85ccaeceb2870f315584fa30121f505a6dfd86439c5e3fdd8cd9e0e291290c41d0c3599f0cb12ab356722ed242584c30348e50
Expand Down Expand Up @@ -13259,30 +13223,6 @@ fsevents@^1.2.7:
languageName: node
linkType: hard

"parse-path@npm:^4.0.0":
version: 4.0.3
resolution: "parse-path@npm:4.0.3"
dependencies:
is-ssh: ^1.3.0
protocols: ^1.4.0
qs: ^6.9.4
query-string: ^6.13.8
checksum: d1704c0027489b64838c608c3f075fe3599c18a7413fa92e7074a0157e5bcc1a4ef73e7ae9bd9dbf5fad1809137437310cc69a57e5f5130ea17226165f3e942a
languageName: node
linkType: hard

"parse-url@npm:^6.0.0":
version: 6.0.0
resolution: "parse-url@npm:6.0.0"
dependencies:
is-ssh: ^1.3.0
normalize-url: ^6.1.0
parse-path: ^4.0.0
protocols: ^1.4.0
checksum: 6b680d1fdfba15fc54106c1130540bf61a415bc3085351b8609a213b2fdf551c53ec8d32703d8ea9b6c5fbf2da92ee1593c99f682032512b15ce87f9013d2a39
languageName: node
linkType: hard

"parse5-htmlparser2-tree-adapter@npm:^6.0.1":
version: 6.0.1
resolution: "parse5-htmlparser2-tree-adapter@npm:6.0.1"
Expand Down Expand Up @@ -14449,13 +14389,6 @@ fsevents@^1.2.7:
languageName: node
linkType: hard

"protocols@npm:^1.1.0, protocols@npm:^1.4.0":
version: 1.4.8
resolution: "protocols@npm:1.4.8"
checksum: 2d555c013df0b05402970f67f7207c9955a92b1d13ffa503c814b5fe2f6dde7ac6a03320e0975c1f5832b0113327865e0b3b28bfcad023c25ddb54b53fab8684
languageName: node
linkType: hard

"proxy-addr@npm:~2.0.5":
version: 2.0.7
resolution: "proxy-addr@npm:2.0.7"
Expand Down Expand Up @@ -14560,34 +14493,13 @@ fsevents@^1.2.7:
languageName: node
linkType: hard

"qs@npm:^6.9.4":
version: 6.10.3
resolution: "qs@npm:6.10.3"
dependencies:
side-channel: ^1.0.4
checksum: 0fac5e6c7191d0295a96d0e83c851aeb015df7e990e4d3b093897d3ac6c94e555dbd0a599739c84d7fa46d7fee282d94ba76943983935cf33bba6769539b8019
languageName: node
linkType: hard

"qs@npm:~6.5.2":
version: 6.5.2
resolution: "qs@npm:6.5.2"
checksum: 24af7b9928ba2141233fba2912876ff100403dba1b08b20c3b490da9ea6c636760445ea2211a079e7dfa882a5cf8f738337b3748c8bdd0f93358fa8881d2db8f
languageName: node
linkType: hard

"query-string@npm:^6.13.8":
version: 6.14.1
resolution: "query-string@npm:6.14.1"
dependencies:
decode-uri-component: ^0.2.0
filter-obj: ^1.1.0
split-on-first: ^1.0.0
strict-uri-encode: ^2.0.0
checksum: f2c7347578fa0f3fd4eaace506470cb4e9dc52d409a7ddbd613f614b9a594d750877e193b5d5e843c7477b3b295b857ec328903c943957adc41a3efb6c929449
languageName: node
linkType: hard

"querystring-es3@npm:^0.2.0":
version: 0.2.1
resolution: "querystring-es3@npm:0.2.1"
Expand Down Expand Up @@ -16507,13 +16419,6 @@ resolve@^1.1.7:
languageName: node
linkType: hard

"split-on-first@npm:^1.0.0":
version: 1.1.0
resolution: "split-on-first@npm:1.1.0"
checksum: 16ff85b54ddcf17f9147210a4022529b343edbcbea4ce977c8f30e38408b8d6e0f25f92cd35b86a524d4797f455e29ab89eb8db787f3c10708e0b47ebf528d30
languageName: node
linkType: hard

"split-string@npm:^3.0.1, split-string@npm:^3.0.2":
version: 3.1.0
resolution: "split-string@npm:3.1.0"
Expand Down Expand Up @@ -16663,13 +16568,6 @@ resolve@^1.1.7:
languageName: node
linkType: hard

"strict-uri-encode@npm:^2.0.0":
version: 2.0.0
resolution: "strict-uri-encode@npm:2.0.0"
checksum: eaac4cf978b6fbd480f1092cab8b233c9b949bcabfc9b598dd79a758f7243c28765ef7639c876fa72940dac687181b35486ea01ff7df3e65ce3848c64822c581
languageName: node
linkType: hard

"string-at@npm:^1.0.1":
version: 1.1.0
resolution: "string-at@npm:1.1.0"
Expand Down