Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Allows for SSH GitHub Repo" #8157

Merged
merged 1 commit into from Mar 3, 2022

Conversation

MelsHyrule
Copy link
Member

@MelsHyrule MelsHyrule commented Mar 3, 2022

Reverts #8122

Currently git-url-parse is not supported in safari. Using this package in safari breaks the application. We've since found this is a known issue: IonicaBizau/git-url-parse#130.

@miq-bot
Copy link
Member

miq-bot commented Mar 3, 2022

Checked commit MelsHyrule@93cff2f with ruby 2.6.7, rubocop 1.19.1, haml-lint 0.35.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🍰

@kavyanekkalapu kavyanekkalapu self-assigned this Mar 3, 2022
@kavyanekkalapu kavyanekkalapu self-requested a review March 3, 2022 20:26
@kavyanekkalapu kavyanekkalapu merged commit d2ae171 into ManageIQ:master Mar 3, 2022
@Fryguy
Copy link
Member

Fryguy commented Mar 4, 2022

Backported to najdorf in commit 9a88f1d.

commit 9a88f1d18d6e29be9ea898974fc15d3371416691
Author: Kavya Nekkalapu <37085529+kavyanekkalapu@users.noreply.github.com>
Date:   Thu Mar 3 15:38:24 2022 -0500

    Merge pull request #8157 from MelsHyrule/revert-8122-adding_ssh
    
    Revert "Allows for SSH GitHub Repo"
    
    (cherry picked from commit d2ae171bdda1f0658ca249b06753442b0e19d481)

Fryguy pushed a commit that referenced this pull request Mar 4, 2022
Revert "Allows for SSH GitHub Repo"

(cherry picked from commit d2ae171)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants