New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Unités] Ajouter un flag "Adresse de diffusion de l'unité" sur les contacts unité #1338
[Unités] Ajouter un flag "Adresse de diffusion de l'unité" sur les contacts unité #1338
Conversation
e7be2b7
to
111ad0d
Compare
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
9429425 | Triggered | Generic Password | 38f0677 | datascience/.env.test | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
backend/src/main/kotlin/fr/gouv/cacem/monitorenv/infrastructure/api/endpoints/BaseController.kt
Outdated
Show resolved
Hide resolved
b621def
to
02dd11b
Compare
5fc1e09
to
733ea2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ça pourrait être pas mal que @claire2212 regarde également cette PR ?
...in/fr/gouv/cacem/monitorenv/domain/use_cases/controlUnit/CreateOrUpdateControlUnitContact.kt
Show resolved
Hide resolved
...in/fr/gouv/cacem/monitorenv/domain/use_cases/controlUnit/CreateOrUpdateControlUnitContact.kt
Outdated
Show resolved
Hide resolved
...d/src/main/kotlin/fr/gouv/cacem/monitorenv/infrastructure/api/adapters/PatchableDataInput.kt
Show resolved
Hide resolved
...d/src/main/kotlin/fr/gouv/cacem/monitorenv/infrastructure/api/adapters/PatchableDataInput.kt
Outdated
Show resolved
Hide resolved
...nitorenv/infrastructure/api/adapters/publicapi/inputs/CreateControlUnitContactDataInputV1.kt
Outdated
Show resolved
Hide resolved
...es/ControlUnit/components/ControlUnitDialog/ControlUnitContactList/Form/FormikPhoneField.tsx
Outdated
Show resolved
Hide resolved
...es/ControlUnit/components/ControlUnitDialog/ControlUnitContactList/Form/FormikPhoneField.tsx
Outdated
Show resolved
Hide resolved
frontend/src/features/MainWindow/dispatchers/addMainWindowBanner.ts
Outdated
Show resolved
Hide resolved
frontend/src/features/ControlUnit/components/ControlUnitDialog/ControlUnitContactList/index.tsx
Outdated
Show resolved
Hide resolved
frontend/src/features/ControlUnit/components/ControlUnitDialog/ControlUnitContactList/index.tsx
Outdated
Show resolved
Hide resolved
frontend/src/features/ControlUnit/components/ControlUnitDialog/ControlUnitContactList/index.tsx
Outdated
Show resolved
Hide resolved
frontend/src/features/ControlUnit/components/ControlUnitDialog/ControlUnitContactList/index.tsx
Outdated
Show resolved
Hide resolved
frontend/src/features/MainWindow/dispatchers/addMainWindowBanner.ts
Outdated
Show resolved
Hide resolved
j'ai repéré deux petits soucis UI :
|
…ol unit contact form
…CreateOrUpdateControlUnitContact use case
…taInput" This reverts commit 4cb2662.
…trationRepository
3a7ed6e
to
8ddad00
Compare
Hello ici, merci @claire2212 du ping. En effet, on peut uniformiser et appliquer la même logique à toute l'interface, à savoir que les messages d'erreur n'apparaissent pas quand le champ est "juste" vide, mais seulement quand il y a un problème avec ce qui a été saisi. |
Related Pull Requests & Issues
Reviewable, only tasks left with @AdelineCelier:
=> UX a bit weird with warning message + banner before saving the form?