Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unités] Ajouter un flag "Adresse de diffusion de l'unité" sur les contacts unité #1338

Merged
merged 48 commits into from May 8, 2024

Conversation

ivangabriele
Copy link
Member

@ivangabriele ivangabriele commented Apr 25, 2024

Related Pull Requests & Issues

Reviewable, only tasks left with @AdelineCelier:

  • Ask for new broadcast/subscription Icon and add it to monitor-ui.
  • Check if saving should be instant when subscribing/unsubscribing or once submit button is clicked (current state)
    => UX a bit weird with warning message + banner before saving the form?
  • Double-check buttons title

  • Tests E2E (Cypress)

@ivangabriele ivangabriele changed the title Ivan/add control unit contact subscriptions [Unités] Ajouter un flag "Adresse de diffusion de l'unité" sur les contacts unité Apr 25, 2024
@ivangabriele ivangabriele force-pushed the ivan/add-control-unit-contact-subscriptions branch 7 times, most recently from e7be2b7 to 111ad0d Compare April 28, 2024 11:54
Copy link

gitguardian bot commented Apr 28, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9429425 Triggered Generic Password 38f0677 datascience/.env.test View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@ivangabriele ivangabriele force-pushed the ivan/add-control-unit-contact-subscriptions branch from b621def to 02dd11b Compare April 29, 2024 15:03
@ivangabriele ivangabriele marked this pull request as ready for review May 1, 2024 09:09
@ivangabriele ivangabriele force-pushed the ivan/add-control-unit-contact-subscriptions branch 2 times, most recently from 5fc1e09 to 733ea2f Compare May 2, 2024 11:20
Copy link
Collaborator

@louptheron louptheron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ça pourrait être pas mal que @claire2212 regarde également cette PR ?

@claire2212
Copy link
Collaborator

j'ai repéré deux petits soucis UI :

  • Quand les champs sont en erreurs (d'ailleurs à valider avec @AdelineCelier s'il faut laisser les messages d'erreurs car on les a enlevé dans les formulaires de missions et de signalements), les boutons de diffusion sont décalés
    Capture d’écran 2024-05-06 à 11 00 28

  • les deux autres petits soucis je ne sait pas d'où ca vient (ta pr, mise à jour de monitor-ui?) :
    Capture d’écran 2024-05-06 à 11 41 31
    :
    Capture d’écran 2024-05-06 à 11 42 22

@ivangabriele ivangabriele merged commit 7ee1ed4 into main May 8, 2024
20 checks passed
@ivangabriele ivangabriele deleted the ivan/add-control-unit-contact-subscriptions branch May 8, 2024 14:58
@AdelineCelier
Copy link
Collaborator

Hello ici, merci @claire2212 du ping. En effet, on peut uniformiser et appliquer la même logique à toute l'interface, à savoir que les messages d'erreur n'apparaissent pas quand le champ est "juste" vide, mais seulement quand il y a un problème avec ce qui a été saisi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ajouter un flag "Adresse de diffusion de l'unité" sur les contacts unité
5 participants