Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for UUID v7 in RequestId #116

Merged

Conversation

NishantJoshi00
Copy link
Contributor

Linked Issue: #115


Description:

feature flag uuid_v7 is introduced which inturn enables v7 feature flag in the uuid dependency Support documentation is added in README.md, src/lib.rs and src/request_id.rs

This feature only works if this crate or any crate dependent on this crate has enabled the compile time configuration flag provided to the rust compiler. RUSTFLAGS="--cfg uuid_unstable".


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

feature flag `uuid_v7` is introduced which inturn enables `v7` feature flag in the `uuid` dependency
Support documentation is added in `README.md`, `src/lib.rs` and `src/request_id.rs`

This feature only works if this crate or any crate dependent on this crate has enabled the compile time configuration flag provided to the rust compiler. `RUSTFLAGS="--cfg uuid_unstable"`.
src/request_id.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@NishantJoshi00
Copy link
Contributor Author

Hey @LukeMathWalker, I have fixed the formatting and the Github action test created for uuid_v7. Let me know if I am missing something.

@LukeMathWalker LukeMathWalker merged commit 410852f into LukeMathWalker:main Oct 20, 2023
12 checks passed
@LukeMathWalker
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants