Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --cfg uuid_unstable requirement for uuid_v7 feature #123

Conversation

SanchithHegde
Copy link
Contributor

Issue #, if available:

Description of changes:

This PR removes the requirement that RUSTFLAGS="--cfg uuid_unstable" be provided to use the uuid_v7 feature flag, and thus the v7 feature flag from the uuid crate.

The uuid crate stabilized support for UUID v6-v8 in uuid-rs/uuid#718, which was included in the 1.6.0 release of the uuid crate. Since tracing-actix-web pulls the uuid crate using only the major version (1) and does not include the minor version, I believe it is safe to remove the --cfg uuid_unstable requirement.

Essentially, I just went through the changes done in #116 and removed some lines which were no longer applicable.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@LukeMathWalker
Copy link
Owner

That works, thanks!

@LukeMathWalker LukeMathWalker merged commit 89363c5 into LukeMathWalker:main Mar 10, 2024
12 checks passed
@SanchithHegde SanchithHegde deleted the uuid-v7-remove-cfg-uuid-unstable branch March 10, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants