Drop ESM entrypoint from package #8493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonkoops
added
blocker
|
@jonkoops Tests are failing |
jonkoops
force-pushed
the
drop-module-entry
branch
from
1330b43
to
40ddc9c
Compare
4 tasks
|
Looks like I forgot to update the build config, should be good now. |
Falke-Design
approved these changes
Sep 29, 2022
4 tasks
mourner
approved these changes
Sep 29, 2022
jonkoops
force-pushed
the
drop-module-entry
branch
from
40ddc9c
to
1d54662
Compare
|
I'm going to revert the entire commit, that way we can be sure that things will continue working as expected. |
jonkoops
force-pushed
the
drop-module-entry
branch
from
1d54662
to
d1902da
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the ESM entrypoint from the package file, as this is causing too many compatibility issues with certain bundlers/tooling.