chore(node): run tests against multiple package managers #648

boneskull · 2023-08-11T00:39:40Z

This changes how lavamoat runs its tests.

To prepare the tests, test/prepare.js is run. This invokes corepack to switch between package managers and performs a clean install and setup using each. The package manager can be changed via environment variable.

Motivation: After changing from Yarn to npm, we were concerned about breaking compat. This should ease our nerves a bit!

Notes:

a new policy file was created in project 2 for atob; I'm not sure what caused this change.
corepack is seemingly broken in Node.js v14 (segfaults); if this is the case, we just try to use the system package manager

chore(core,node): add some types for scenarios and options

boneskull · 2023-08-11T00:44:21Z

Closes #625 (possibly)

boneskull · 2023-08-11T00:46:45Z

@legobeat I suppose we could also add yarn berry, but I know it won't be so easy. I would like to better understand how exactly this package is consumed by yarn berry users.

boneskull · 2023-08-15T19:16:09Z

Current dependencies on/for this PR:

main
- PR fix!: drop Node.js v14 #729
  - PR chore(node): run tests against multiple package managers #648 👈

This comment was auto-generated by Graphite.

failing tests resolved

no changes afterall

naugtur · 2023-09-26T09:58:50Z

now that we're no longer supporting node 14 this should be smooth

boneskull · 2023-09-26T20:16:51Z

This now targets #729 and I removed the terrible garbage I had to add for v14.

naugtur

I think we forgot about his one. Without node14 it looks nice and clean.

This changes how `lavamoat` runs its tests. To prepare the tests, `test/prepare.js` is run. This invokes [corepack](https://npm.im/corepack) to switch between package managers and performs a clean install and setup using each. The package manager can be changed via environment variable. Motivation: After changing from Yarn to npm, we were concerned about breaking compat. This should ease our nerves a bit! Notes: - a new policy file was created in project `2` for `atob`; I'm not sure what caused this change. - Yarn _must_ have lockfiles or it will get confused about workspaces.

legobeat · 2023-10-24T03:31:40Z

packages/node/package.json

+    "test": "npm run test:npm && npm run test:yarn1",
+    "test:prepare": "node ./test/prepare.js",
+    "test:npm": "cross-env LAVAMOAT_PM=npm@latest npm run test:prepare && ava",
+    "test:yarn1": "cross-env LAVAMOAT_PM=yarn@1 npm run test:prepare && ava",
+    "lint:deps": "depcheck"


Suggested change

"test": "npm run test:npm && npm run test:yarn1",

"test:prepare": "node ./test/prepare.js",

"test:npm": "cross-env LAVAMOAT_PM=npm@latest npm run test:prepare && ava",

"test:yarn1": "cross-env LAVAMOAT_PM=yarn@1 npm run test:prepare && ava",

"lint:deps": "depcheck"

"lint:deps": "depcheck",

"test": "npm run test:npm && npm run test:yarn1",

"test:npm": "cross-env LAVAMOAT_PM=npm@latest npm run test:prepare && ava",

"test:prepare": "node ./test/prepare.js",

"test:yarn1": "cross-env LAVAMOAT_PM=yarn@1 npm run test:prepare && ava"

nit: alphabetic order

there's a prettier plugin to sort package.json. I suggest we use it

legobeat · 2023-10-24T03:34:10Z

packages/node/test/projects/2/package.json

  },
  "dependencies": {
    "keccak": "3.0.0"
  },
  "devDependencies": {
-    "patch-package": "^6.2.2"
+    "patch-package": "6.2.2"


As we're pinning, could we do so on 6.5.1? (Latest for ^6.2.2)

I'm going to go with "no" for now, because it doesn't work on my machine:

Command failed: /Users/boneskull/projects/lavamoat/lavamoat/packages/node/test/../src/cli.js ./index.js Error: No native build was found for platform=darwin arch=arm64 runtime=node abi=115 uv=1 armv=8 libc=glibc node=20.9.0 loaded from: /Users/boneskull/projects/lavamoat/lavamoat/packages/node/test/projects/2/node_modules/keccak at load.resolve.load.path (/Users/boneskull/projects/lavamoat/lavamoat/packages/node/test/projects/2/node_modules/node-gyp-build/node-gyp-build.js:61:9) at Object.eval (/Users/boneskull/projects/lavamoat/lavamoat/packages/node/test/projects/2/node_modules/keccak/bindings.js:2:73) at internalRequire (LavaMoat/core/kernel:896:27) at requireRelative (LavaMoat/core/kernel:941:27) at requireRelativeWithContext (LavaMoat/core/kernel:909:18) at Object.eval (/Users/boneskull/projects/lavamoat/lavamoat/packages/node/test/projects/2/node_modules/keccak/index.js:2:18) at internalRequire (LavaMoat/core/kernel:896:27) at requireRelative (LavaMoat/core/kernel:941:27) at requireRelativeWithContext (LavaMoat/core/kernel:909:18) at Object.eval (/Users/boneskull/projects/lavamoat/lavamoat/packages/node/test/projects/2/index.js:11:26)

legobeat · 2023-10-24T03:36:44Z

package.json

@@ -30,8 +31,12 @@
    "type-fest": "^2.19.0",
    "typescript": "^5.2.2"
  },
+  "optionalDependencies": {
+    "corepack": "0.20.0"


(could) slightly loosen range to not have to manually apply any future non-breaking changes/fixes:

Suggested change

"corepack": "0.20.0"

"corepack": "~0.20.0"

There's nothing to upgrade to. corepack is on v0.22.0 now, and requires Node.js v18.

boneskull force-pushed the boneskull/policy-schema branch from 7cf3c57 to 94ad4cd Compare August 11, 2023 00:42

boneskull force-pushed the boneskull/smoke branch from 30360d6 to 082eb13 Compare August 11, 2023 00:42

boneskull force-pushed the boneskull/smoke branch from 082eb13 to 6910e3e Compare August 11, 2023 00:45

boneskull requested review from legobeat, naugtur and kumavis August 11, 2023 00:45

boneskull self-assigned this Aug 11, 2023

boneskull added the chore overhead, tests, dev env, etc. label Aug 11, 2023

boneskull force-pushed the boneskull/policy-schema branch from 94ad4cd to 1f13e6e Compare August 11, 2023 04:55

boneskull force-pushed the boneskull/smoke branch 4 times, most recently from b82d7e5 to c66024b Compare August 15, 2023 19:14

boneskull changed the base branch from boneskull/policy-schema to boneskull/normalize-test-filenames August 15, 2023 19:15

boneskull force-pushed the boneskull/smoke branch from c66024b to dc9c9da Compare August 15, 2023 19:15

boneskull changed the base branch from boneskull/normalize-test-filenames to boneskull/policy-schema August 15, 2023 20:45

boneskull force-pushed the boneskull/smoke branch from dc9c9da to c64c8e2 Compare August 15, 2023 20:45

boneskull mentioned this pull request Aug 15, 2023

chore(node,core): add more test types #651

Merged

boneskull force-pushed the boneskull/smoke branch 2 times, most recently from b4c7ca5 to 9dddc50 Compare September 19, 2023 00:09

boneskull force-pushed the boneskull/smoke branch 3 times, most recently from 8766e95 to e780f61 Compare September 25, 2023 20:39

boneskull changed the base branch from main to boneskull/issue616-drop-v14 September 26, 2023 20:15

boneskull force-pushed the boneskull/smoke branch from e780f61 to e10da2d Compare September 26, 2023 20:15

boneskull mentioned this pull request Sep 26, 2023

fix!: drop Node.js v14 #729

Merged

boneskull force-pushed the boneskull/smoke branch from e10da2d to 255bfd5 Compare September 26, 2023 20:16

boneskull force-pushed the boneskull/issue616-drop-v14 branch from 9bb74cd to f42003e Compare October 5, 2023 00:07

boneskull force-pushed the boneskull/smoke branch from 255bfd5 to 0d7bd14 Compare October 5, 2023 00:07

boneskull force-pushed the boneskull/issue616-drop-v14 branch from f42003e to 6c17c97 Compare October 5, 2023 17:59

boneskull force-pushed the boneskull/smoke branch from 0d7bd14 to 9faedbb Compare October 5, 2023 17:59

Base automatically changed from boneskull/issue616-drop-v14 to main October 5, 2023 18:00

boneskull force-pushed the boneskull/smoke branch 2 times, most recently from a0c494b to 1643a69 Compare October 5, 2023 21:22

boneskull force-pushed the boneskull/smoke branch from 1643a69 to 6fa40d3 Compare October 20, 2023 00:01

naugtur approved these changes Oct 23, 2023

View reviewed changes

boneskull added 2 commits October 23, 2023 15:34

chore(ci): fix some tags

6114b89

boneskull force-pushed the boneskull/smoke branch from 6fa40d3 to 8e3daa8 Compare October 23, 2023 22:35

legobeat reviewed Oct 24, 2023

View reviewed changes

boneskull merged commit 7e8e354 into main Oct 26, 2023
11 checks passed

boneskull deleted the boneskull/smoke branch October 26, 2023 19:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(node): run tests against multiple package managers #648

chore(node): run tests against multiple package managers #648

boneskull commented Aug 11, 2023

boneskull commented Aug 11, 2023

boneskull commented Aug 11, 2023

boneskull commented Aug 15, 2023 •

edited

naugtur commented Sep 26, 2023

boneskull commented Sep 26, 2023

naugtur left a comment

legobeat Oct 24, 2023 •

edited

boneskull Oct 26, 2023

legobeat Oct 24, 2023

boneskull Oct 26, 2023

legobeat Oct 24, 2023 •

edited

boneskull Oct 26, 2023

chore(node): run tests against multiple package managers #648

chore(node): run tests against multiple package managers #648

Conversation

boneskull commented Aug 11, 2023

boneskull commented Aug 11, 2023

boneskull commented Aug 11, 2023

boneskull commented Aug 15, 2023 • edited

naugtur commented Sep 26, 2023

boneskull commented Sep 26, 2023

naugtur left a comment

Choose a reason for hiding this comment

legobeat Oct 24, 2023 • edited

Choose a reason for hiding this comment

boneskull Oct 26, 2023

Choose a reason for hiding this comment

legobeat Oct 24, 2023

Choose a reason for hiding this comment

boneskull Oct 26, 2023

Choose a reason for hiding this comment

legobeat Oct 24, 2023 • edited

Choose a reason for hiding this comment

boneskull Oct 26, 2023

Choose a reason for hiding this comment

boneskull commented Aug 15, 2023 •

edited

legobeat Oct 24, 2023 •

edited

legobeat Oct 24, 2023 •

edited