chore(deps): remove @metamask/eslint-config-nodejs #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 31, 2023
Merged
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
boneskull
force-pushed
the
boneskull/consolidate-eslint
branch
from
fb5c7c7
to
d71fb9f
Compare
boneskull
force-pushed
the
boneskull/issue637-mm-eslint-node
branch
from
da3d434
to
f10548b
Compare
boneskull
force-pushed
the
boneskull/consolidate-eslint
branch
from
d71fb9f
to
ca03621
Compare
boneskull
force-pushed
the
boneskull/issue637-mm-eslint-node
branch
from
f10548b
to
2656b19
Compare
boneskull
force-pushed
the
boneskull/consolidate-eslint
branch
from
ca03621
to
d31f9eb
Compare
boneskull
force-pushed
the
boneskull/issue637-mm-eslint-node
branch
from
2656b19
to
44a72eb
Compare
boneskull
force-pushed
the
boneskull/consolidate-eslint
branch
from
d31f9eb
to
a753724
Compare
boneskull
force-pushed
the
boneskull/issue637-mm-eslint-node
branch
from
44a72eb
to
e14a16b
Compare
boneskull
force-pushed
the
boneskull/consolidate-eslint
branch
from
a753724
to
62bb6ea
Compare
boneskull
force-pushed
the
boneskull/issue637-mm-eslint-node
branch
from
e14a16b
to
98f6de1
Compare
boneskull
force-pushed
the
boneskull/consolidate-eslint
branch
from
62bb6ea
to
6ec7fce
Compare
boneskull
force-pushed
the
boneskull/issue637-mm-eslint-node
branch
from
98f6de1
to
4f6c1ab
Compare
This was referenced Aug 15, 2023
boneskull
force-pushed
the
boneskull/consolidate-eslint
branch
from
6ec7fce
to
6657c9b
Compare
boneskull
force-pushed
the
boneskull/issue637-mm-eslint-node
branch
from
4f6c1ab
to
0f3f25b
Compare
Closes #637 This removes the dep on `@metamask/eslint-config-nodejs` which has a peer dep on `@metamask/eslint-config`. `npm` will automatically install that module, and that module _itself_ has peer deps which may also conflict with our deps currently or in the future. Given `@metamask/eslint-config-nodejs` is _intended_ to be used with `@metamask/eslint-config`, we then must drop it. The ESLint config has been modified to extend both `eslint/recommended` and `eslint-plugin-n/recommended` configs. Extra rules were copied from `@metamask/eslint-config-nodejs`, but many (such as restrictions on browser-only globals) were not, since these can be trivially addressed by ESLint's `env` configuration (unsure what they are doing where this is a problem). Since this surfaced a whole lot of new issues--especially in test code and templates--additional overrides were necessary. Any rules which were removed from the main `rules` prop were likely already enabled in `eslint/recommended`.
boneskull
force-pushed
the
boneskull/consolidate-eslint
branch
from
6657c9b
to
be1ccb5
Compare
boneskull
force-pushed
the
boneskull/issue637-mm-eslint-node
branch
from
0f3f25b
to
766d478
Compare
naugtur
approved these changes
Aug 17, 2023
boneskull
added a commit
that referenced
this pull request
Aug 22, 2023
This change: - Removes all `.eslintignore` , `.eslintrc` files or `package.json`-embedded config and replaces it with a single root `.eslintrc.js` - Removes all lint-related scripts from all workspaces (including `depcheck`) - Removes all dev deps on `eslint` and its ilk (and `ava`, since it will come from the workspace root) - Upgrade `eslint`, `eslint-plugin-ava`, as well as other plugins used by specific packages; moves them all to workspace root - Removes unused/deprecated `eslint-plugin-node` in lieu of `eslint-plugin-n` - Adds a prettier config (in case someone wants to use it; I'd like to add it to our workflow later) I note that ESLint seemed to be misconfigured before this change; none of the rules specified in the root config were being checked. This means that there are a whole lot of lint fixes that need to be made. To lint, run `yarn lint` as before (which will also run `depcheck`) from the workspace root. Likewise, `lint:fix` runs a fix, and `lint:depcheck` will use lerna to run `lint:depcheck` wherever it is defined. chore: remove @metamask/eslint-config-nodejs (#639) Closes #637 This removes the dep on `@metamask/eslint-config-nodejs` which has a peer dep on `@metamask/eslint-config`. `npm` will automatically install that module, and that module _itself_ has peer deps which may also conflict with our deps currently or in the future. Given `@metamask/eslint-config-nodejs` is _intended_ to be used with `@metamask/eslint-config`, we then must drop it. The ESLint config has been modified to extend both `eslint/recommended` and `eslint-plugin-n/recommended` configs. Extra rules were copied from `@metamask/eslint-config-nodejs`, but many (such as restrictions on browser-only globals) were not, since these can be trivially addressed by ESLint's `env` configuration (unsure what they are doing where this is a problem). Since this surfaced a whole lot of new issues--especially in test code and templates--additional overrides were necessary. Any rules which were removed from the main `rules` prop were likely already enabled in `eslint/recommended`. chore: lint everything
boneskull
added a commit
to boneskull/LavaMoat
that referenced
this pull request
Feb 6, 2024
This change: - Removes all `.eslintignore` , `.eslintrc` files or `package.json`-embedded config and replaces it with a single root `.eslintrc.js` - Removes all lint-related scripts from all workspaces (including `depcheck`) - Removes all dev deps on `eslint` and its ilk (and `ava`, since it will come from the workspace root) - Upgrade `eslint`, `eslint-plugin-ava`, as well as other plugins used by specific packages; moves them all to workspace root - Removes unused/deprecated `eslint-plugin-node` in lieu of `eslint-plugin-n` - Adds a prettier config (in case someone wants to use it; I'd like to add it to our workflow later) I note that ESLint seemed to be misconfigured before this change; none of the rules specified in the root config were being checked. This means that there are a whole lot of lint fixes that need to be made. To lint, run `yarn lint` as before (which will also run `depcheck`) from the workspace root. Likewise, `lint:fix` runs a fix, and `lint:depcheck` will use lerna to run `lint:depcheck` wherever it is defined. chore: remove @metamask/eslint-config-nodejs (LavaMoat#639) Closes LavaMoat#637 This removes the dep on `@metamask/eslint-config-nodejs` which has a peer dep on `@metamask/eslint-config`. `npm` will automatically install that module, and that module _itself_ has peer deps which may also conflict with our deps currently or in the future. Given `@metamask/eslint-config-nodejs` is _intended_ to be used with `@metamask/eslint-config`, we then must drop it. The ESLint config has been modified to extend both `eslint/recommended` and `eslint-plugin-n/recommended` configs. Extra rules were copied from `@metamask/eslint-config-nodejs`, but many (such as restrictions on browser-only globals) were not, since these can be trivially addressed by ESLint's `env` configuration (unsure what they are doing where this is a problem). Since this surfaced a whole lot of new issues--especially in test code and templates--additional overrides were necessary. Any rules which were removed from the main `rules` prop were likely already enabled in `eslint/recommended`. chore: lint everything
boneskull
added a commit
to boneskull/LavaMoat
that referenced
this pull request
Feb 6, 2024
This change: - Removes all `.eslintignore` , `.eslintrc` files or `package.json`-embedded config and replaces it with a single root `.eslintrc.js` - Removes all lint-related scripts from all workspaces (including `depcheck`) - Removes all dev deps on `eslint` and its ilk (and `ava`, since it will come from the workspace root) - Upgrade `eslint`, `eslint-plugin-ava`, as well as other plugins used by specific packages; moves them all to workspace root - Removes unused/deprecated `eslint-plugin-node` in lieu of `eslint-plugin-n` - Adds a prettier config (in case someone wants to use it; I'd like to add it to our workflow later) I note that ESLint seemed to be misconfigured before this change; none of the rules specified in the root config were being checked. This means that there are a whole lot of lint fixes that need to be made. To lint, run `yarn lint` as before (which will also run `depcheck`) from the workspace root. Likewise, `lint:fix` runs a fix, and `lint:depcheck` will use lerna to run `lint:depcheck` wherever it is defined. chore: remove @metamask/eslint-config-nodejs (LavaMoat#639) Closes LavaMoat#637 This removes the dep on `@metamask/eslint-config-nodejs` which has a peer dep on `@metamask/eslint-config`. `npm` will automatically install that module, and that module _itself_ has peer deps which may also conflict with our deps currently or in the future. Given `@metamask/eslint-config-nodejs` is _intended_ to be used with `@metamask/eslint-config`, we then must drop it. The ESLint config has been modified to extend both `eslint/recommended` and `eslint-plugin-n/recommended` configs. Extra rules were copied from `@metamask/eslint-config-nodejs`, but many (such as restrictions on browser-only globals) were not, since these can be trivially addressed by ESLint's `env` configuration (unsure what they are doing where this is a problem). Since this surfaced a whole lot of new issues--especially in test code and templates--additional overrides were necessary. Any rules which were removed from the main `rules` prop were likely already enabled in `eslint/recommended`. chore: lint everything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #637
This removes the dep on
@metamask/eslint-config-nodejswhich has a peer dep on@metamask/eslint-config.npmwill automatically install that module, and that module itself has peer deps which may also conflict with our deps currently or in the future.Given
@metamask/eslint-config-nodejsis intended to be used with@metamask/eslint-config, we then must drop it.The ESLint config has been modified to extend both
eslint/recommendedandeslint-plugin-n/recommendedconfigs. Extra rules were copied from@metamask/eslint-config-nodejs, but many (such as restrictions on browser-only globals) were not, since these can be trivially addressed by ESLint'senvconfiguration (unsure what they are doing where this is a problem). Since this surfaced a whole lot of new issues--especially in test code and templates--additional overrides were necessary. Any rules which were removed from the mainrulesprop were likely already enabled ineslint/recommended.