Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking change: Guava future coroutine builder shouldn't report to CoroutineExceptionHandler #2840

Merged
merged 2 commits into from Sep 30, 2021
Merged

Breaking change: Guava future coroutine builder shouldn't report to CoroutineExceptionHandler #2840

merged 2 commits into from Sep 30, 2021

Commits on Jul 23, 2021

  1. Breaking change: guava future coroutine builder shouldn't report to C… 

    …oroutineExceptionHandler.

See  Kotlin#2774 and Kotlin#2791 for more context.

This change makes `future` coroutine builder consistent with `java.util.concurrent.FutureTask` which also drops exceptions that happens after successful cancellation.
    @vadimsemenov
    vadimsemenov committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    7bfe527 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2021

  1. Follow test name convention in ListenableFutureTest 

    https://github.com/Kotlin/kotlinx.coroutines/blob/master/CONTRIBUTING.md#submitting-prs
    @vadimsemenov
    vadimsemenov committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    3d89bcc View commit details
    Browse the repository at this point in the history