Breaking change: Guava future coroutine builder shouldn't report to CoroutineExceptionHandler #2840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oroutineExceptionHandler. See Kotlin#2774 and Kotlin#2791 for more context. This change makes `future` coroutine builder consistent with `java.util.concurrent.FutureTask` which also drops exceptions that happens after successful cancellation.
|
Gentle ping :) |
qwwdfsad
approved these changes
Sep 27, 2021
There was a problem hiding this comment.
Thanks for the detailed documentation and fix! The changes look good to me.
Is it okay to ask you to do the same in CompletableFuture builder within this PR?
I suspect it is prone to the same issue.
It's completely okay if you are short on time, your contribution is valuable and appreciated as is.
integration/kotlinx-coroutines-guava/test/ListenableFutureTest.kt
Outdated
Show resolved
Hide resolved
|
I can look into |
|
Sure, thanks for taking care of it! |
yorickhenning
pushed a commit
to yorickhenning/kotlinx.coroutines
that referenced
this pull request
Oct 14, 2021
…oroutineExceptionHandler (Kotlin#2840) This change makes `future` coroutine builder consistent with `java.util.concurrent.FutureTask` which also drops exceptions that happen after successful cancellation. Fixes Kotlin#2774 Fixes Kotlin#2791
pablobaxter
pushed a commit
to pablobaxter/kotlinx.coroutines
that referenced
this pull request
Sep 14, 2022
…oroutineExceptionHandler (Kotlin#2840) This change makes `future` coroutine builder consistent with `java.util.concurrent.FutureTask` which also drops exceptions that happen after successful cancellation. Fixes Kotlin#2774 Fixes Kotlin#2791
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2774 and #2791.
This change makes
futurecoroutine builder consistent withjava.util.concurrent.FutureTaskwhich also drops exceptions that happen after successful cancellation.Note:
futurewill still pass the error to its parent in the tree if there's one. But if there's no parent, the exception is dropped.