fix: dump with Konnect is missing Kong version #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 39.79% // Head: 39.78% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #758 +/- ##
==========================================
- Coverage 39.79% 39.78% -0.01%
==========================================
Files 87 87
Lines 9884 9885 +1
==========================================
Hits 3933 3933
- Misses 5572 5573 +1
Partials 379 379
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Recently we made `decK` more aware of the `_format_version` value, which require fetching the Kong version from Admin API. This is not possible for Konnect right now, so we just hardcoded it for `sync`, but missed it for the `dump` command. This commit is fixing it.
GGabriele
force-pushed
the
fix/dump-konnect
branch
from
69d8f8c
to
3ffa574
Compare
aboudreault
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we made
decKmore aware of the_format_versionvalue, which require fetching the Kong version from Admin API. This is not possible for Konnect right now, so we just hardcoded it forsync, but missed it for thedumpcommand.This commit is fixing it.