Skip to content

Commit

Permalink
fix: dump with Konnect is missing Kong version
Browse files Browse the repository at this point in the history
Recently we made `decK` more aware of the `_format_version` value,
which require fetching the Kong version from Admin API.
This is not possible for Konnect right now, so we just hardcoded
it for `sync`, but missed it for the `dump` command.

This commit is fixing it.
  • Loading branch information
GGabriele committed Sep 27, 2022
1 parent c7262ae commit 3ffa574
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
11 changes: 11 additions & 0 deletions CHANGELOG.md
@@ -1,5 +1,6 @@
# Table of Contents

- [v1.15.1](#v1151)
- [v1.15.0](#v1150)
- [v1.14.0](#v1140)
- [v1.13.0](#v1130)
Expand Down Expand Up @@ -44,6 +45,15 @@
- [v0.2.0](#v020)
- [v0.1.0](#v010)

## [v1.15.1]

> Release date: 2022/09/27
### Fixes

- Fix decK dump when running against Konnect
[#758](https://github.com/Kong/deck/pull/758)

## [v1.15.0]

> Release date: 2022/09/26
Expand Down Expand Up @@ -1021,6 +1031,7 @@ No breaking changes have been introduced in this release.

Debut release of decK

[v1.15.1]: https://github.com/kong/deck/compare/v1.15.0...v1.15.1
[v1.15.0]: https://github.com/kong/deck/compare/v1.14.0...v1.15.0
[v1.14.0]: https://github.com/kong/deck/compare/v1.13.0...v1.14.0
[v1.13.0]: https://github.com/kong/deck/compare/v1.12.4...v1.13.0
Expand Down
1 change: 1 addition & 0 deletions cmd/common_konnect.go
Expand Up @@ -161,6 +161,7 @@ func dumpKonnectV2(ctx context.Context) error {
FileFormat: file.Format(strings.ToUpper(konnectDumpCmdStateFormat)),
WithID: dumpWithID,
RuntimeGroupName: konnectRuntimeGroup,
KongVersion: defaultFetchedKongVersion,
})
}

Expand Down

0 comments on commit 3ffa574

Please sign in to comment.