New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added header for apps #823
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the line to set the header to each api method instead of the configure method, this way it's easier to remove it when the beta period is over (example). You could make the configure
method private and call it in each api method for example. Thanks!
Certainly! |
@acrobat is there a release schedule? |
@AAllport There is no planned release schedule, but I'm planning on publishing a new release soon as there are many fixed/features since last release! |
Looking forward to it! |
Well that's ruddy mysterious |
@AAllport the travis error is not related to these changes but something incorrectly merged on master, I've pushed a fix to the master branch. Can you rebase your branch onto master? Thanks! |
My git foo isn't quite as good as some be. |
@AAllport A merge is fine! I will squash the commits when merging the pr! |
Thanks a lot @AAllport! And congrats on your first contribution! 🎉 |
For what it's worth, I believe this is my 1st functional OSS contribution, 10/10 would definitely recommend 😁 |
See: https://developer.github.com/v3/apps
Fixes: #800