New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing Apps endpoints #814
Conversation
Small change on the configure method requested, the rest of the PR looks good! |
@jamiehuson can you rebase you PR against the current master? And use the |
5f43ffd
to
73c2cbf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 small remarks, the rest of the PR looks good! 👍
Thanks @jamiehuson! And congrats on your first contribution! 🎉 |
Why make this change?
Some endpoints available on https://developer.github.com/v3/apps/ are not available through this package. I also added the Accept header back for the preview Apps apis, which addresses this issue: #800
Considerations
I did not include Create Github App from App-Manifest because that flow required additional scoping to fully understand the flow, which was beyond the scope of my needs at this time.
Testing
I have included tests for all added endpoints.