Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update highlightjs version #1503

Merged
merged 2 commits into from Jan 18, 2021
Merged

Update highlightjs version #1503

merged 2 commits into from Jan 18, 2021

Conversation

laborg
Copy link
Contributor

@laborg laborg commented Jan 6, 2021

The update to the newest version of highlightjs pulls in the work of @fredrikekre to improve julia and julia-repl. This won't work on IE11, but ¯_(ツ)_/¯...

The CSS files haven't changed with this update.

@mortenpi mortenpi added this to the 0.27.0 milestone Jan 16, 2021
Copy link
Member

@mortenpi mortenpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @laborg!

CHANGELOG.md Show resolved Hide resolved
@mortenpi mortenpi added Format: HTML Related to the default HTML output Type: Enhancement labels Jan 18, 2021
@mortenpi
Copy link
Member

I'll go ahead and merge this, since it looks like the CHANGELOG is fine as is.

Looks like IE11 has just 1% of users nowadays so maybe not even worth mentioning?

Meh. Might as well mention it, since it's already there. You're right, though, in that this should have no noticeable effect on Julia users.

@mortenpi mortenpi merged commit eea5e5c into JuliaDocs:master Jan 18, 2021
@kimikage
Copy link
Contributor

As mentioned in #1458 (comment), highlight.js v10 warns the invalid class "language-none".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Format: HTML Related to the default HTML output Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants