Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix highlight.js warning due to invalid "language-none" #1551

Merged
merged 1 commit into from Mar 16, 2021

Conversation

kimikage
Copy link
Contributor

In highlight.js v10, only "nohighlight" and "no-highlight" are valid for ignoring highlighting.

WARN: Could not find the language 'none', did you forget to load/include a language module?

@mortenpi mortenpi added Format: HTML Related to the default HTML output Type: Bug labels Mar 15, 2021
@mortenpi mortenpi added this to the 0.27.0 milestone Mar 15, 2021
Copy link
Member

@mortenpi mortenpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would you mind adding the PR reference to the corresponding entry in the CHANGELOG as well?

In highlight.js v10, only "nohighlight" and "no-highlight" are
valid for ignoring highlighting.
@kimikage
Copy link
Contributor Author

kimikage commented Mar 15, 2021

I figured this was an attachment to PR #1503, so I added the PR reference after that number.

FYI, highlight.js v10.6 has already been released, and the initialization API has been changed.
(cf. https://github.com/highlightjs/highlight.js/blob/master/CHANGES.md#version-1060)
However, I don't think it needs to be updated urgently.

@mortenpi
Copy link
Member

Thanks @kimikage!

@mortenpi mortenpi merged commit fba03cc into JuliaDocs:master Mar 16, 2021
@kimikage kimikage deleted the nohighlight branch March 16, 2021 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Format: HTML Related to the default HTML output Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants