Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper 7.0+ dependency. #13

Merged
merged 1 commit into from Apr 24, 2020
Merged

Use proper 7.0+ dependency. #13

merged 1 commit into from Apr 24, 2020

Conversation

dereuromark
Copy link
Contributor

Many tools are currently blocked from updating/using to composer v2 due to your package using the Ocramius package, which already now is 7.4+.
Many of us are software vendors that need to keep libraries 7.2 compatible, and that cannot be done using this package right now.
The composer guys offered a way to do that using this package until everyone is safely beyond 7.4+.
But given the policy of how this library is run, I would advice to keep using the composer version here even beyond that (the problem wont go away).

See also Ocramius/PackageVersions#133 to why this is necessary.

@Seldaek
Copy link

Seldaek commented Apr 24, 2020

Also note that for Composer 2 users, using https://github.com/composer/composer/blob/master/src/Composer/InstalledVersions.php is preferred as the source of information IMO.

Please read the getPrettyVersion/getVersion docs carefully though, as ocramius/package-versions was kinda naive there in terms of handling replace/provide. Reality is more complex, and getVersion is thus not guaranteed to return a single version. Using satisfies is preferred.

The other question is whether this package has still a reason to exist or not though in a Composer 2 world, I am not sure if there is enough added value but I will let you be the judge of that.

@dereuromark
Copy link
Contributor Author

dereuromark commented Apr 24, 2020

OK, that's fair. Actually, we would need this here more to resolve the current status quo (of trying to force-keep that package 7.2 compatible with some hacks).
So basically, as v2 preparation, not as v2 migration.

If v2 has built in package-versions, that's even more awesome :)

@Jean85
Copy link
Owner

Jean85 commented Apr 24, 2020

Thanks @Seldaek and @dereuromark for your work. I'm delving a little in how all of this works.

The other question is whether this package has still a reason to exist or not though in a Composer 2 world, I am not sure if there is enough added value but I will let you be the judge of that.

Well, this was just a tiny wrapper around Ocramius' package; depending on the output of Composer v2, it could still be needed. I'll investigate this immediately.

@Jean85 Jean85 merged commit aabcd52 into Jean85:master Apr 24, 2020
@dereuromark dereuromark deleted the patch-1 branch April 24, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants