Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Composer 2 natively #14

Closed
Jean85 opened this issue Apr 24, 2020 · 6 comments · Fixed by #15
Closed

Support Composer 2 natively #14

Jean85 opened this issue Apr 24, 2020 · 6 comments · Fixed by #15
Assignees
Milestone

Comments

@Jean85
Copy link
Owner

Jean85 commented Apr 24, 2020

After #13, we support both Composer 1 and 2, but we're forced to rely on the forked dependency to do that.

We now could release a new version (1.4?) that would require Composer 2, but drop the dependency. In this way, any consumer of this package could still rely on ^1.0 of this package, without tying to a specific Composer version, but having a smooth upgrade path nonetheless, and dropping the additional dependency as soon as possible.

@Jean85 Jean85 self-assigned this Apr 24, 2020
@Jean85 Jean85 changed the title Support Composer 2 Support Composer 2 natively Apr 24, 2020
@Jean85
Copy link
Owner Author

Jean85 commented Apr 28, 2020

Released as 1.4.

@Jean85
Copy link
Owner Author

Jean85 commented Jun 19, 2020

Reopening, since due to #21 I decided to re-release Composer 2 native support as 2.0

@Jean85 Jean85 reopened this Jun 19, 2020
@Jean85 Jean85 added this to the 2.0 milestone Jun 19, 2020
@alexander-schranz
Copy link

alexander-schranz commented Jan 11, 2021

@Jean85 any update to this? The follwing issue of sentry getsentry/sentry-symfony#383 does make me problems for me and errors.

@Jean85
Copy link
Owner Author

Jean85 commented Jan 12, 2021

I did not have much time in the last months to work on OSS, sorry.

@alexander-schranz
Copy link

alexander-schranz commented Jan 12, 2021

No problem. I invistigated some more time and I'm not sure if its really on your side the issue I linked, as there are 2 composer autoloader loaded the second one override the first one and that makes the problem, that it can not find the version.

I posted a workaround here: getsentry/sentry-symfony#383 (comment)

@Jean85
Copy link
Owner Author

Jean85 commented Jan 15, 2021

Closing this as it got released: https://github.com/Jean85/pretty-package-versions/releases/tag/2.0.0

@Jean85 Jean85 closed this as completed Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants