Skip to content
This repository has been archived by the owner on Jan 14, 2019. It is now read-only.

feat: distinct type alias from variable in AST #44

Closed
wants to merge 1 commit into from

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Dec 2, 2018

Do not merge this commit before #43

#17 eslint/typescript-eslint-parser#414

@armano2 armano2 changed the title feat: distinct type alias from variable in AST WIP: feat: distinct type alias from variable in AST Dec 2, 2018
@armano2 armano2 changed the title WIP: feat: distinct type alias from variable in AST feat: distinct type alias from variable in AST Dec 5, 2018
@armano2 armano2 force-pushed the type-alias branch 3 times, most recently from c4ade1e to f73935a Compare December 5, 2018 20:54
BREAKING CHANGE: This changes the AST
@JamesHenry
Copy link
Owner

I would have expected us to be able to include previously ignored ast-alignment-tests when making this change. Is that not the case?

@armano2 armano2 mentioned this pull request Dec 15, 2018
@armano2
Copy link
Contributor Author

armano2 commented Dec 16, 2018

@JamesHenry as suggested by @ikatyang i merged this PR to #42 and enabled there a lot alignment tests

@JamesHenry JamesHenry closed this Dec 19, 2018
@armano2 armano2 deleted the type-alias branch December 19, 2018 02:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants