This repository has been archived by the owner on Jan 14, 2019. It is now read-only.
feat: fix issues in AST #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i feel like i should split this PR cus alignment changes are getting big |
armano2
force-pushed
the
align-nodes
branch
2 times, most recently
from
7507043
to
89f2fea
Compare
|
@armano2 Got some conflicts from merging your other PR. Please could you also be sure to add: As the body of your commit That will trigger a major version to be released and for the release notes to contain info about the breaking change. @ikatyang @j-f1 Please could you take a look at this, this will undoubtedly affect prettier |
|
@JamesHenry thats why i wanted to split this to few commits, and looks like i'm going to do so. |
BREAKING CHANGE: This changes the AST
|
@JamesHenry updated |
ikatyang
reviewed
Dec 15, 2018
BREAKING CHANGE: This changes the AST
|
@JamesHenry is there something i have to change in this PR? |
JamesHenry
approved these changes
Dec 19, 2018
|
🎉 This PR is included in version 7.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Dec 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
declareto nodes:changes:
DeclareFunctiontoTSDeclareFunctionchanges:
VariableDeclarator[kind='type']toTSTypeAliasDeclarationmakes
abstractoptional in interfacesfixes: #17 eslint/typescript-eslint-parser#414