Add a wait-free intrusive stack data structure #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WFIStack is added to the set of experimental data structures. This data structure has, from experience, proven useful for implementing a number of other concurrency primitives.
Pull Request Test Coverage Report for Build 698
💛 - Coveralls |
franz1981
requested changes
Jun 19, 2020
There was a problem hiding this comment.
Very happy about this: probably will give another round but it looks good to me. I'm not here in charge to decide but after a thinking time into the experimental parking area I suppose this could be nice addition to the JCTools core family :)
Well done and hi :)
jctools-experimental/src/main/java/org/jctools/stacks/WFIStack.java
Outdated
Show resolved
Hide resolved
jctools-experimental/src/main/java/org/jctools/stacks/WFIStack.java
Outdated
Show resolved
Hide resolved
|
Thanks @chrisvest ! this is interesting, I'll have a close read next week :-) |
- Remove `Thread.yield()` call in spin-wait loop. - Add padding around the `WFIStack.head` field. - Add a push/pop concurrent stress/sanity test for WFIStack.
nitsanw
reviewed
Jun 30, 2020
jctools-experimental/src/main/java/org/jctools/stacks/WFIStack.java
Outdated
Show resolved
Hide resolved
nitsanw
reviewed
Jun 30, 2020
jctools-experimental/src/main/java/org/jctools/stacks/WFIStack.java
Outdated
Show resolved
Hide resolved
nitsanw
reviewed
Jun 30, 2020
jctools-experimental/src/main/java/org/jctools/stacks/WFIStack.java
Outdated
Show resolved
Hide resolved
|
Currently working on adding a benchmark. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WFIStack is added to the set of experimental data structures.
This data structure has, from experience, proven useful for implementing a number of other concurrency primitives.
Let me know if this is interesting.