Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize-url v3 is vulnerable #130

Closed
lykims opened this issue Jun 29, 2021 · 2 comments · Fixed by #138
Closed

normalize-url v3 is vulnerable #130

lykims opened this issue Jun 29, 2021 · 2 comments · Fixed by #138

Comments

@lykims
Copy link
Contributor

lykims commented Jun 29, 2021

Following the issues IonicaBizau/parse-url#19 and IonicaBizau/git-up#24, git-url-parse should have an updated version of git-up to fix the vulnerability.

Two versions to verify:

  • git-up@5.0.0 uses parse-url@6.0.0 that uses normalize-url@6.1.0, and normalize-url@6.1.0 does not seem to be compatible with Safari.
  • parse-url@5.0.7 only requires normalize-url@4.5.1 which seems to be OK with Safari. See if git-up could have another version that uses parse-url@5.0.7.

Details about the security issue: https://www.npmjs.com/advisories/1755

@IonicaBizau
Copy link
Owner

Thank you for this, @lykims! I will try to solve this ASAP...

@agoldis
Copy link

agoldis commented Jul 31, 2021

For those who need Safari support, inline version w/o normalize-url

https://gist.github.com/agoldis/05aa28e09aa8e549733242bb86834712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants