Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

normalize-url v3 is vulnerable #24

Closed
lykims opened this issue Jun 9, 2021 · 3 comments
Closed

normalize-url v3 is vulnerable #24

lykims opened this issue Jun 9, 2021 · 3 comments

Comments

@lykims
Copy link

lykims commented Jun 9, 2021

Following the issue IonicaBizau/parse-url#19, git-up should have the latest version of parse-url as well.

Details about the security issue: https://www.npmjs.com/advisories/1755
@lykims lykims mentioned this issue Jun 9, 2021
Closed
@IonicaBizau
Copy link
Owner

This should be fixed now. 😄 Thank you!

@lykims lykims mentioned this issue Jun 29, 2021
Closed
@lykims
Copy link
Author

lykims commented Jun 29, 2021

Hi @IonicaBizau!

From your comment IonicaBizau/parse-url#19 (comment), should git-up have another version as well?

I also created the issue IonicaBizau/git-url-parse#130.

@IonicaBizau
Copy link
Owner

Hi @lykims! I am not sure what to do here: normalize-url should get a patch for Safari, ideally... git-up now uses parse-url@6.x.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update parse-url version to 5.0.3 lykims/git-up
2 participants
@lykims @IonicaBizau