Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with unwanted color in DrawLineModifer #1348

Merged
merged 5 commits into from
May 7, 2024

Conversation

olivervogel
Copy link
Member

See #1347

@olivervogel
Copy link
Member Author

olivervogel commented May 5, 2024

The bug is fixed and the tests are successful in the GitHub workflow, but for unknown reasons there is an error in the Docker test environment.

docker-compose run --build --rm tests

[...]

There was 1 failure:
                                                                                  
1) Intervention\Image\Tests\Unit\Drivers\Gd\Modifiers\DrawLineModifierTest::testApplyTransparent
Failed asserting that color rgba(255, 255, 255, 255) equals rgba(255, 129, 66, 255)
Failed asserting that an array contains 255.

/project/tests/BaseTestCase.php:79
/project/tests/Unit/Drivers/Gd/Modifiers/DrawLineModifierTest.php:36

Could be related to GD Version bundled (2.1.0 compatible), which is approx. 8 years old and not supported anymore. The error does not occur with the current GD version 2.3.3.

This must be investigated before the fix can be merged.

@olivervogel olivervogel linked an issue May 5, 2024 that may be closed by this pull request
This test only fails with no longer supported GD lib version 2.1.
The docker container of the test environment comes unfortunately with
with version and I have not yet managed to install a more recent version.

Unfortunately, adding the PHPUnit attribute #RequiresPhpExtension
with version number does not work either.
@olivervogel olivervogel merged commit 7f33feb into develop May 7, 2024
12 checks passed
@olivervogel olivervogel deleted the bugfix/draw-line-modifier branch May 7, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DrawLine with unwanted colors (Imagick)
1 participant