Merge pull request #1348 from Intervention/bugfix/draw-line-modifier

Fix bug with unwanted color in DrawLineModifer
Intervention · May 7, 2024 · 7f33feb · 7f33feb
2 parents 2e0cbf2 + 9a013b9
commit 7f33feb
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
@@ -89,7 +89,10 @@ jobs:
       - name: Install dependencies
         run: composer update --${{ matrix.stability }} --prefer-dist --no-interaction
 
-      - name: Which Imagick Version
+      - name: GD Version
+        run: php -r 'var_dump(gd_info());'
+
+      - name: Imagick Version
         run: php -r 'var_dump(Imagick::getVersion());'
 
       - name: Supported Imagick Formats

diff --git a/src/Drivers/Imagick/Modifiers/DrawLineModifier.php b/src/Drivers/Imagick/Modifiers/DrawLineModifier.php
@@ -19,6 +19,7 @@ public function apply(ImageInterface $image): ImageInterface
     {
         $drawing = new ImagickDraw();
         $drawing->setStrokeWidth($this->drawable->width());
+        $drawing->setFillOpacity(0);
         $drawing->setStrokeColor(
             $this->driver()->colorProcessor($image->colorspace())->colorToNative(
                 $this->backgroundColor()

diff --git a/tests/Unit/Drivers/Imagick/Modifiers/DrawLineModifierTest.php b/tests/Unit/Drivers/Imagick/Modifiers/DrawLineModifierTest.php
@@ -25,4 +25,14 @@ public function testApply(): void
         $image->modify(new DrawLineModifier($line));
         $this->assertEquals('b53517', $image->pickColor(0, 0)->toHex());
     }
+
+    public function testApplyTransparent(): void
+    {
+        $image = $this->createTestImage(10, 10)->fill('ff5500');
+        $this->assertColor(255, 85, 0, 255, $image->pickColor(5, 5));
+        $line = new Line(new Point(0, 5), new Point(10, 5), 4);
+        $line->setBackgroundColor('fff4');
+        $image->modify(new DrawLineModifier($line));
+        $this->assertColor(255, 136, 77, 255, $image->pickColor(5, 5));
+    }
 }