Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump gson from 2.8.8 to 2.8.9 #190

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 1, 2021

Bumps gson from 2.8.8 to 2.8.9.

Release notes

Sourced from gson's releases.

Gson 2.8.9

  • Make OSGi bundle's dependency on sun.misc optional (#1993).
  • Deprecate Gson.excluder() exposing internal Excluder class (#1986).
  • Prevent Java deserialization of internal classes (#1991).
  • Improve number strategy implementation (#1987).
  • Fix LongSerializationPolicy null handling being inconsistent with Gson (#1990).
  • Support arbitrary Number implementation for Object and Number deserialization (#1290).
  • Bump proguard-maven-plugin from 2.4.0 to 2.5.1 (#1980).
  • Don't exclude static local classes (#1969).
  • Fix RuntimeTypeAdapterFactory depending on internal Streams class (#1959).
  • Improve Maven build (#1964).
  • Make dependency on java.sql optional (#1707).
Changelog

Sourced from gson's changelog.

Version 2.8.9

  • Make OSGi bundle's dependency on sun.misc optional (#1993).
  • Deprecate Gson.excluder() exposing internal Excluder class (#1986).
  • Prevent Java deserialization of internal classes (#1991).
  • Improve number strategy implementation (#1987).
  • Fix LongSerializationPolicy null handling being inconsistent with Gson (#1990).
  • Support arbitrary Number implementation for Object and Number deserialization (#1290).
  • Bump proguard-maven-plugin from 2.4.0 to 2.5.1 (#1980).
  • Don't exclude static local classes (#1969).
  • Fix RuntimeTypeAdapterFactory depending on internal Streams class (#1959).
  • Improve Maven build (#1964).
  • Make dependency on java.sql optional (#1707).
Commits
  • 6a368d8 [maven-release-plugin] prepare release gson-parent-2.8.9
  • ba96d53 Fix missing bounds checks for JsonTreeReader.getPath() (#2001)
  • ca1df7f #1981: Optional OSGi bundle's dependency on sun.misc package (#1993)
  • c54caf3 Deprecate Gson.excluder() exposing internal Excluder class (#1986)
  • e6fae59 Prevent Java deserialization of internal classes (#1991)
  • bda2e3d Improve number strategy implementation (#1987)
  • cd748df Fix LongSerializationPolicy null handling being inconsistent with Gson (#1990)
  • fe30b85 Support arbitrary Number implementation for Object and Number deserialization...
  • 1cc1627 Fix incorrect feature request template label (#1982)
  • 7b9a283 Bump bnd-maven-plugin from 5.3.0 to 6.0.0 (#1985)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [gson](https://github.com/google/gson) from 2.8.8 to 2.8.9.
- [Release notes](https://github.com/google/gson/releases)
- [Changelog](https://github.com/google/gson/blob/master/CHANGELOG.md)
- [Commits](google/gson@gson-parent-2.8.8...gson-parent-2.8.9)

---
updated-dependencies:
- dependency-name: com.google.code.gson:gson
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner November 1, 2021 12:04
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 1, 2021
@eiri
Copy link
Member

eiri commented Nov 1, 2021

well, this fails consistently with tons of java.lang.NoSuchFieldError: NUMBER

@eiri
Copy link
Member

eiri commented Nov 1, 2021

The root case of this failure is the fact that as a part of google/gson#1290 type adapter NUMBER was removed from JSON and core's using it in its gson singleton implementation to prevent serialization round-tripping problems (ironically an issue raised by us).

Hence this dep bump is now blocked until it's addressed in core lib.

@eiri
Copy link
Member

eiri commented Nov 5, 2021

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 5, 2021

Looks like com.google.code.gson:gson is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Nov 5, 2021
@dependabot dependabot bot deleted the dependabot/maven/com.google.code.gson-gson-2.8.9 branch November 5, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant