Improve number strategy implementation #1987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marcono1234
commented
Oct 11, 2021
| @@ -71,11 +71,11 @@ | |||
| try { | |||
| Double d = Double.valueOf(value); | |||
| if ((d.isInfinite() || d.isNaN()) && !in.isLenient()) { | |||
| throw new MalformedJsonException("JSON forbids NaN and infinities: " + d + in); | |||
| throw new MalformedJsonException("JSON forbids NaN and infinities: " + d + "; at path " + in.getPath()); | |||
There was a problem hiding this comment.
Uses getPath() instead of (implicit) in.toString() because the line and column number included by toString() would point behind the value (since it has already been consumed).
|
@lyubomyr-shaydariv are these changes alright for you? |
|
@Marcono1234 absolutely! I can't even recall what I implemented more than 3 years ago, but if you see it's not that good, I totally trust you! @eamonnmcmanus Please consider merging these changes: I find them really good making #1290 better until it's released. Thank you! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #1290 for some things I overlooked when I reviewed the changes a while ago.