Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix types export in package.json #317

Closed
wants to merge 1 commit into from
Closed

fix: fix types export in package.json #317

wants to merge 1 commit into from

Conversation

kyletsang
Copy link
Contributor

Move the types declaration in the exports field to the top. According to the TS docs, the types field needs to come first.

https://www.typescriptlang.org/docs/handbook/esm-node.html#packagejson-exports-imports-and-self-referencing

The "types" condition should always come first in "exports".

@kyletsang
fix: fix types export in package.json
0294754 
Signed-off-by: kyletsang <6854874+kyletsang@users.noreply.github.com>
@quinnturner quinnturner mentioned this pull request Dec 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kyletsang