Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING: Require Node 18, support ESM and CJS #319

Merged
merged 12 commits into from
Dec 10, 2023
Merged

BREAKING: Require Node 18, support ESM and CJS #319

merged 12 commits into from
Dec 10, 2023

Conversation

quinnturner
Copy link
Member

@quinnturner quinnturner commented Sep 23, 2023 •
edited

Drop support for Node <18. This is a security library; we must enforce secure Node.js versioning practices 😄

Are the types wrong report

audit-ci git:(esm-cjs) ✗ bunx attw ./audit-ci-7.0.0.tgz

audit-ci v7.0.0

Build tools:
- typescript@^5.3.3

 No problems found 🌟


"audit-ci"

node10: 🟢 
node16 (from CJS): 🟢 (CJS)
node16 (from ESM): 🟢 (ESM)
bundler: 🟢 

***********************************

"audit-ci/package.json"

node10: 🟢 (JSON)
node16 (from CJS): 🟢 (JSON)
node16 (from ESM): 🟢 (JSON)
bundler: 🟢 (JSON)

***********************************

@quinnturner quinnturner changed the title BREAKING: Require Node 16, support ESM and CJS BREAKING: Require Node 18, support ESM and CJS Dec 10, 2023
@quinnturner quinnturner merged commit c863fee into IBM:main Dec 10, 2023
6 of 7 checks passed
@quinnturner quinnturner deleted the esm-cjs branch December 10, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@quinnturner