Upgrade integers() backend and filter rewriting
#2878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
force-pushed
the
efficient-filter
branch
from
92ea349
to
504da7b
Compare
Via a morning paging through noisy output from pylint and some proprietary services.
This was referenced Mar 15, 2021
This was referenced Mar 15, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the implementation of
integers(), so that it consists only of anIntegersStrategyclass instead of various combinations, maps, and filters over separate classes for bounded and unbounded integers.Data-generation is logically unchanged, with negligible performance changes in runtime and memory usage - the real motivation here is to empower runtime introspection for filter-rewriting (#2701) and prototyping symbolic execution.