Filter-rewriting for st.floats()
#3385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
added
enhancement
Zac-HD
force-pushed
the
efficient-floats-filters
branch
2 times, most recently
from
f02fb36
to
60b823f
Compare
Zac-HD
force-pushed
the
efficient-floats-filters
branch
from
60b823f
to
b8f7d50
Compare
|
@honno - if this looks good to you, please approve and merge! (if not, please leave a review explaining why you don't think it's ready me merge yet) |
honno
previously approved these changes
Jun 27, 2022
There was a problem hiding this comment.
LGTM! Familiarised myself with the filter.py stuff generally now, very neat.
(feel free to request reviews—I'll either get it done in a few days... or just silently ignore, indicating I probably won't be reviewing 😅)
(hmm having tests fail locally, one sec...)
honno
dismissed
their stale review
had local tests failures just want to explore... should of probably ran them first
honno
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the remaining pieces of #2701, following the
integers()support in #2853 and #2878.Thanks to @pschanely for #3327 which made this possible!