various formulae: replace compound unless with if

[SeekingMeaning]

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

This is part of Homebrew/brew#10256, which adds a rubocop that disallows unless statements with multiple conditions

Truth table for reference:

p	q	!(p && q)	!p || !q	!(p || q)	!p && !q
F	F	T	T	T	T
F	T	T	T	F	F
T	F	T	T	F	F
T	T	F	F	F	F

[carlocab]

I don't mind getting rid of unlesss, but simultaneously making the substitution

!(p && q) => (!p) || (!q)

is, I think, a regression for readability. I'd prefer you just stuck with the !(p && q) form. Or does rubocop complain about those too?

[SeekingMeaning]

Yes, it doesn't like if !condition

[SeekingMeaning]

An alternative is to create a variable and then do unless variable

[carlocab]

Nah, that's annoying too. Your changes are fine then.

[BrewTestBot]

🤖 A scheduled task has triggered a merge.