New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rubocops: add unless_multiple_conditions
#10256
rubocops: add unless_multiple_conditions
#10256
Conversation
Review period will end on 2021-01-08 at 23:12:39 UTC. |
Library/Homebrew/test/rubocops/unless_multiple_conditions_spec.rb
Outdated
Show resolved
Hide resolved
f63fc01
to
be2406d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work here as usual @SeekingMeaning and impressive turnaround on this 👏🏻
be2406d
to
2a80427
Compare
Review period ended. |
@SeekingMeaning Looks like we may be able to replace this with rubocop/rubocop#9386 after the next RuboCop release? 🤞🏻 |
Opened #10770 |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?brew man
locally and committed any changes?Follow-up to #10245 (comment)
This PR adds the
UnlessMultipleConditions
rubocop, based on rubocop/rubocop#5400unless
withif
homebrew-core#68527Disallowed
unless
statements:Truth table for reference: