Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocops: add unless_multiple_conditions #10256

Merged

Conversation

SeekingMeaning
Copy link
Contributor

@SeekingMeaning SeekingMeaning commented Jan 7, 2021

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Have you successfully run brew man locally and committed any changes?

Follow-up to #10245 (comment)

This PR adds the UnlessMultipleConditions rubocop, based on rubocop/rubocop#5400

Disallowed unless statements:

unless foo && bar
  something
end
something unless foo || bar

Truth table for reference:

p q !(p && q) !p || !q !(p || q) !p && !q
FFTTTT
FTTTFF
TFTTFF
TTFFFF

@BrewTestBot
Copy link
Member

Review period will end on 2021-01-08 at 23:12:39 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 7, 2021
@SeekingMeaning SeekingMeaning force-pushed the unless_multiple_conditions branch 3 times, most recently from f63fc01 to be2406d Compare January 8, 2021 08:30
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here as usual @SeekingMeaning and impressive turnaround on this 👏🏻

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Jan 9, 2021
@BrewTestBot
Copy link
Member

Review period ended.

@SeekingMeaning SeekingMeaning merged commit c8afe19 into Homebrew:master Jan 9, 2021
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 9, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 9, 2021
@MikeMcQuaid
Copy link
Member

@SeekingMeaning Looks like we may be able to replace this with rubocop/rubocop#9386 after the next RuboCop release? 🤞🏻

@SeekingMeaning
Copy link
Contributor Author

Opened #10770

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants