Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

observerward: fix test when built with rust 1.67.0 #121737

Closed
wants to merge 1 commit into from

Conversation

ZhongRuoyu
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

In #121561 observerward segfaulted due to an undefined behaviour in dependency prettytable-rs (see phsym/prettytable-rs#145). That could be fixed by bumping prettytable-rs to 0.10.0, which upstream has done in 0x727/ObserverWard#103.

@BrewTestBot BrewTestBot added the rust Rust use is a significant feature of the PR or issue label Jan 28, 2023
@ZhongRuoyu ZhongRuoyu mentioned this pull request Jan 28, 2023
@ZhongRuoyu
Copy link
Member Author

==> cargo update --package prettytable-rs --precise 0.10.0
    Updating crates.io index
warning: spurious network error (2 tries remaining): SecureTransport error: connection closed via error; class=Net (12)
warning: spurious network error (1 tries remaining): SecureTransport error: connection closed via error; class=Net (12)
error: Unable to update registry `crates-io`

Triggering a new run.

@chenrui333
Copy link
Member

rebase per the rust 1.67.0 merge

@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Jan 29, 2023
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@ZhongRuoyu ZhongRuoyu deleted the observerward-test branch January 29, 2023 18:28
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 1, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age ready to merge PR can be merged once CI is green rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants