Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust 1.67.0 #121561

Closed
wants to merge 1 commit into from
Closed

rust 1.67.0 #121561

wants to merge 1 commit into from

Conversation

ZhongRuoyu
Copy link
Member

@ZhongRuoyu ZhongRuoyu commented Jan 26, 2023

Created by brew bump


Created with brew bump-formula-pr.

resource blocks may require updates.

@BrewTestBot BrewTestBot added bump-formula-pr PR was created using `brew bump-formula-pr` CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. long build Needs CI-long-timeout labels Jan 26, 2023
@chenrui333 chenrui333 added CI-long-timeout Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Jan 26, 2023
@chenrui333
Copy link
Member

failed with cargo-zigbuild on linux build, https://github.com/Homebrew/homebrew-core/actions/runs/4016616611/jobs/6900416401

rust: update resources
Signed-off-by: Rui Chen <rui@chenrui.dev>
@ZhongRuoyu
Copy link
Member Author

ZhongRuoyu commented Jan 27, 2023

failed with cargo-zigbuild on linux build, https://github.com/Homebrew/homebrew-core/actions/runs/4016616611/jobs/6900416401

Smells like OOM:

  [ 99%] Building stage2 object /tmp/zig-20230126-105481-vy2xnk/zig-0.10.1/build/zig2.o
  cd /tmp/zig-20230126-105481-vy2xnk/zig-0.10.1 && /tmp/zig-20230126-105481-vy2xnk/zig-0.10.1/build/zig1 src/stage1.zig --name zig2 --zig-lib-dir /tmp/zig-20230126-105481-vy2xnk/zig-0.10.1/lib -femit-bin=/tmp/zig-20230126-105481-vy2xnk/zig-0.10.1/build/zig2.o -fcompiler-rt -target native -mcpu native -lc --pkg-begin build_options /tmp/zig-20230126-105481-vy2xnk/zig-0.10.1/build/config.zig --pkg-end
  Killed

Update: Yeah, this also happened in #121008. If this is still happening, CI-linux-self-hosted Build on Linux self-hosted runner may be needed.

@chenrui333 chenrui333 added the CI-linux-self-hosted Build on Linux self-hosted runner label Jan 27, 2023
@chenrui333
Copy link
Member

failed with cargo-zigbuild on linux build, https://github.com/Homebrew/homebrew-core/actions/runs/4016616611/jobs/6900416401

Smells like OOM:

  [ 99%] Building stage2 object /tmp/zig-20230126-105481-vy2xnk/zig-0.10.1/build/zig2.o
  cd /tmp/zig-20230126-105481-vy2xnk/zig-0.10.1 && /tmp/zig-20230126-105481-vy2xnk/zig-0.10.1/build/zig1 src/stage1.zig --name zig2 --zig-lib-dir /tmp/zig-20230126-105481-vy2xnk/zig-0.10.1/lib -femit-bin=/tmp/zig-20230126-105481-vy2xnk/zig-0.10.1/build/zig2.o -fcompiler-rt -target native -mcpu native -lc --pkg-begin build_options /tmp/zig-20230126-105481-vy2xnk/zig-0.10.1/build/config.zig --pkg-end
  Killed

Update: Yeah, this also happened in #121008. If this is still happening, CI-linux-self-hosted Build on Linux self-hosted runner may be needed.

that makes sense, but I can followup separately though if just cargo-zigbuild failure again.

@ZhongRuoyu ZhongRuoyu mentioned this pull request Jan 27, 2023
@chenrui333
Copy link
Member

some compilation issues for dependencies of pueue and sn0int

brew install --build-from-source pueue
brew install --build-from-source sn0int

@ZhongRuoyu
Copy link
Member Author

ZhongRuoyu commented Jan 27, 2023

Not counting ignored ones on Ventura:

macOS ARM & Intel

macOS Intel

  • brew install --build-from-source watchman: Instruction set issue when poured from bottle, also seen previously (rust 1.66.0 #118242 (comment)). Reproducible on macOS Intel when built from source locally.

@p-linnane p-linnane removed the CI-long-timeout Use longer GitHub Actions CI timeout. label Jan 27, 2023
@BrewTestBot
Copy link
Member

:shipit: @chenrui333 has triggered a merge.

@chenrui333
Copy link
Member

All rust deps are build deps, merging it now and will followup with this list.

@ZhongRuoyu ZhongRuoyu deleted the bump-rust-1.67.0 branch January 29, 2023 15:24
@Nukesor
Copy link

Nukesor commented Feb 8, 2023

brew install --build-from-source pueue: Related to Nukesor/pueue#409. Its dependency darwin-libproc had its repo removed from GitHub. Not sure what can be done here.

This has been fixed by creating our own fork.
We're also working actively with another Mac procfs crate to merge some fixes upstream, so we no longer depend on this abandoned library and and can use a proper crate instead of a github repo.

Should I publish a new point release to fix this? Right now this is only on main and I didn't think of publishing a new release, as this is only a dev-dependency.

@ZhongRuoyu
Copy link
Member Author

Thanks, @Nukesor.

Should I publish a new point release to fix this? Right now this is only on main and I didn't think of publishing a new release, as this is only a dev-dependency.

If possible, yes, please, since currently a source build of pueue's stable version still results in the same error.

Cc maintainer @chenrui333 on this.

@mjpieters
Copy link
Contributor

I'm on the libproc issue; we contributed to another, maintained project to cover the functionality we need and I'm about to rip out darwin-libproc. :-)

@Nukesor
Copy link

Nukesor commented Feb 8, 2023

New minor release has been published :)

@ZhongRuoyu ZhongRuoyu mentioned this pull request Feb 8, 2023
6 tasks
@ZhongRuoyu
Copy link
Member Author

Thanks, @Nukesor and @mjpieters! I opened #122681.

@github-actions github-actions bot added the outdated PR was locked due to age label Mar 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-linux-self-hosted Build on Linux self-hosted runner CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. long build Needs CI-long-timeout outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants