Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator-sdk: update go to latest (1.18.x) #103381

Closed

Conversation

everettraven
Copy link
Contributor

@everettraven everettraven commented Jun 10, 2022

In a previous PR [1] I downgraded the Go dependency of Operator-SDK to Go 1.17 as Operator-SDK did not yet support Go 1.18.

The next release of Operator-SDK (v1.22.0) is going to support Go 1.18. It has not yet been released but I am creating this PR prior to the next release so it can be ready to merge when the next release is created and used in the formula.

If there is anything else that I need to do, just let me know!

[1] - #101238

operator-sdk issue for tracking this change: operator-framework/operator-sdk#5740

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Leaving some of the checks unmarked as it is currently expected that the tests will fail because the release to support Go 1.18 has not been released yet.

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@BrewTestBot BrewTestBot added the go Go use is a significant feature of the PR or issue label Jun 10, 2022
@carlocab carlocab changed the title (operator-sdk): update go to latest (1.18.x) operator-sdk: update go to latest (1.18.x) Jun 10, 2022
@chenrui333
Copy link
Member

merge this into #103706

@chenrui333 chenrui333 closed this Jun 15, 2022
@chenrui333 chenrui333 added the superseded PR was replaced by another PR label Jun 15, 2022
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
go Go use is a significant feature of the PR or issue outdated PR was locked due to age superseded PR was replaced by another PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants