Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Homebrew Formula when Go 1.18 is supported. #5740

Closed
everettraven opened this issue May 9, 2022 · 7 comments
Closed

Update Homebrew Formula when Go 1.18 is supported. #5740

everettraven opened this issue May 9, 2022 · 7 comments
Assignees
Labels
priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Milestone

Comments

@everettraven
Copy link
Contributor

Feature Request

Describe the problem you need a feature to resolve.

At the time of writing, Operator SDK does not support Go 1.18. This resulted in changing the Homebrew Formula for operator-sdk to be dependent on Go 1.17.

Describe the solution you'd like.

When Go 1.18 is supported the Homebrew Formula for operator-sdk needs to be updated to have the proper Go dependency.

@varshaprasad96 varshaprasad96 added this to the v1.21.0 milestone May 16, 2022
@varshaprasad96 varshaprasad96 modified the milestones: v1.21.0, v1.22.0 May 16, 2022
@varshaprasad96 varshaprasad96 added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Jun 8, 2022
@asmacdo
Copy link
Member

asmacdo commented Jun 10, 2022

Should be good to go on this as soon as #5843 merges

@everettraven
Copy link
Contributor Author

This should not be closed, this is meant to track updating the homebrew formula in the homebrew/homebrew-core repository

@everettraven everettraven reopened this Jun 10, 2022
@camilamacedo86
Copy link
Contributor

Hi @everettraven ,

We do not maintain the homebrew formula.

However, when we do the release from master it will work fine because the problem was that homebrew install go 1.18 and SDK and Go 1.18 was not supported yet.

@everettraven
Copy link
Contributor Author

@camilamacedo86 This issue was created here so the maintainers in the homebrew-core repo would allow me to downgrade go to 1.17 when we did not support go 1.18. I am going to link them to this issue when upgrading the homebrew formula to support go 1.18.

@camilamacedo86
Copy link
Contributor

That is fine. Thank you for share

@everettraven
Copy link
Contributor Author

PR in progress (waiting for automated version bump to take place): Homebrew/homebrew-core#103381

@everettraven
Copy link
Contributor Author

Merged into homebrew/core as of: Homebrew/homebrew-core@5eeea04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Development

No branches or pull requests

4 participants