Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detach chromium from shell script PID when using brew provided wrapper #104850

Merged
merged 2 commits into from
May 4, 2021
Merged

detach chromium from shell script PID when using brew provided wrapper #104850

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c1ee0d
When invoked from command line use exec to replace shell
fbessett Apr 30, 2021
70c60ea
Update chromium.rb
miccal May 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions Casks/chromium.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
cask "chromium" do
version "875978"
sha256 "d9a58514abbd3eb6b48e58e47d0223771f77435892c2040ebca277075b5bb1f8"
version "878726"
sha256 "b3e8559bf657d48253570602e8894333684b862485e54c0b409a19c492857a18"

url "https://commondatastorage.googleapis.com/chromium-browser-snapshots/Mac/#{version}/chrome-mac.zip",
verified: "commondatastorage.googleapis.com/chromium-browser-snapshots/Mac/"
Expand All @@ -26,7 +26,7 @@
preflight do
IO.write shimscript, <<~EOS
#!/bin/sh
'#{appdir}/Chromium.app/Contents/MacOS/Chromium' "$@"
exec '#{appdir}/Chromium.app/Contents/MacOS/Chromium' "$@"
EOS
end

Expand Down