detach chromium from shell script PID when using brew provided wrapper #104850
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple shell wrapper is provided to execute chromium from command line.
The way it is defined, chromium will have the PID
/bin/sh
as PPID:I'm using chromedp to interact with
chromium/Chrome
, and thisbehaviour triggers some issues. When the execution context is done in
the library, it triggers the termination of the shell process instead of the chromium process and
chromium is left as an orphan process on the system.
There is an open issue documenting this behaviour here
Using
exec
will detachchomium
process from the shell, and will provideexpected behaviour when called with such libraries; user
experience when calling
chromium
from the shell will not change.Thank you.
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
After making all changes to a cask, verify:
brew audit --cask {{cask_file}}
is error-free.brew style --fix {{cask_file}}
reports no offenses.Additionally, if adding a new cask:
brew audit --new-cask {{cask_file}}
worked successfully.brew install --cask {{cask_file}}
worked successfully.brew uninstall --cask {{cask_file}}
worked successfully.