Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump RuboCop version (1.38.0) #156

Merged
merged 5 commits into from
Nov 10, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
inherit_from: .rubocop_todo.yml

Metrics/ClassLength:
Max: 500

Metrics/MethodLength:
Max: 20

Naming/InclusiveLanguage:
Enabled: True

# Excluding spec files
AllCops:
NewCops: enable
TargetRubyVersion: 2.6.5p114
TargetRubyVersion: 2.7.0
Exclude:
- 'spec/*'
- 'vendor/**/*'
Expand Down
Empty file removed .rubocop_todo.yml
Empty file.
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,5 @@ group :test do
gem 'code-scanning-rubocop'
gem 'rspec'
gem 'rspec_junit_formatter'
gem 'rubocop', '= 1.9.1'
gem 'rubocop'
end
26 changes: 14 additions & 12 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ GEM
httpclient (2.8.3)
i18n (1.8.10)
concurrent-ruby (~> 1.0)
json (2.6.2)
jwt (2.2.3)
little-plugger (1.1.4)
logging (2.3.1)
Expand All @@ -68,17 +69,17 @@ GEM
faraday (>= 0.9)
sawyer (~> 0.8.0, >= 0.5.3)
openssl (3.0.0)
parallel (1.20.1)
parser (3.0.0.0)
parallel (1.22.1)
parser (3.1.2.1)
ast (~> 2.4.1)
psych (4.0.4)
stringio
public_suffix (4.0.6)
rack (2.2.3.1)
rainbow (3.0.0)
rainbow (3.1.1)
rdoc (6.4.0)
psych (>= 4.0.0)
regexp_parser (2.1.1)
regexp_parser (2.6.0)
rexml (3.2.5)
rspec (3.10.0)
rspec-core (~> 3.10.0)
Expand All @@ -95,17 +96,18 @@ GEM
rspec-support (3.10.2)
rspec_junit_formatter (0.4.1)
rspec-core (>= 2, < 4, != 2.12.0)
rubocop (1.9.1)
rubocop (1.38.0)
json (~> 2.3)
parallel (~> 1.10)
parser (>= 3.0.0.0)
parser (>= 3.1.2.1)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 1.8, < 3.0)
rexml
rubocop-ast (>= 1.2.0, < 2.0)
rexml (>= 3.2.5, < 4.0)
rubocop-ast (>= 1.23.0, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 1.4.0, < 3.0)
rubocop-ast (1.4.1)
parser (>= 2.7.1.5)
rubocop-ast (1.23.0)
parser (>= 3.1.1.0)
ruby-progressbar (1.11.0)
ruby2_keywords (0.0.4)
rubyntlm (0.6.3)
Expand All @@ -124,7 +126,7 @@ GEM
stringio (3.0.2)
tzinfo (2.0.4)
concurrent-ruby (~> 1.0)
unicode-display_width (2.0.0)
unicode-display_width (2.3.0)
winrm (2.3.4)
builder (>= 2.1.2)
erubi (~> 1.8)
Expand Down Expand Up @@ -157,7 +159,7 @@ DEPENDENCIES
rspec
rspec_junit_formatter
rtoolsHCK!
rubocop (= 1.9.1)
rubocop
rubyzip
sentry-ruby
sqlite3
Expand Down
4 changes: 2 additions & 2 deletions lib/setupmanagers/hckclient.rb
Original file line number Diff line number Diff line change
Expand Up @@ -190,8 +190,8 @@ def synchronize(exit: false)
end

def not_ready?
@studio.list_pools.detect { |pool| pool['name'].eql?(@pool) }['machines']\
.detect { |machine| machine['name'].eql?(@name) }['state']\
@studio.list_pools.detect { |pool| pool['name'].eql?(@pool) }['machines']
.detect { |machine| machine['name'].eql?(@name) }['state']
.eql?('NotReady')
end

Expand Down
4 changes: 2 additions & 2 deletions lib/trap.rb
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ def self.normal_trap(signal)
perform_trap(signal)
else
@sig_timestamps[signal] = time
write_log("SIG#{signal}(1) received, aborting if another SIG#{signal} is"\
' received in the span of the next one second')
write_log("SIG#{signal}(1) received")
write_log("Aborting if another SIG#{signal} is received in the span of the next one second")
end
end

Expand Down