Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump RuboCop version (1.38.0) #156

Merged
merged 5 commits into from Nov 10, 2022
Merged

Bump RuboCop version (1.38.0) #156

merged 5 commits into from Nov 10, 2022

Conversation

kostyanf14
Copy link
Contributor

No description provided.

akihikodaki
akihikodaki requested changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@akihikodaki akihikodaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see that the new version of RuboCop finds more room of improvements. I added comments where I came up with alternatives to fix new offenses.

lib/config/sentry.rb Outdated Show resolved Hide resolved
lib/setupmanagers/qemuhck/network_manager.rb Outdated Show resolved Hide resolved
lib/setupmanagers/qemuhck/qemu_machine.rb Outdated Show resolved Hide resolved
lib/trap.rb Outdated Show resolved Hide resolved
bin/ns_unshared Outdated Show resolved Hide resolved
lib/setupmanagers/hckclient.rb Outdated Show resolved Hide resolved
lib/auxiliary/id_gen.rb Outdated Show resolved Hide resolved
@akihikodaki akihikodaki mentioned this pull request Nov 7, 2022
Merged
@kostyanf14
hckclient: remove extra backslash
fa7f558 
Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>
@kostyanf14
trap: Split log into several lines
c9d8cad 
Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>
@kostyanf14
rubocop: Remove empty config
03bad82 
Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>
@kostyanf14
rubocop: Bump target ruby version to minimal supported
6e7a99d 
Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>
@kostyanf14
Bump RuboCop version (1.38.0)
f921b9f 
Signed-off-by: Kostiantyn Kostiuk <konstantin@daynix.com>
@YanVugenfirer YanVugenfirer merged commit f90de56 into HCK-CI:master Nov 10, 2022
@kostyanf14 kostyanf14 deleted the rubocop branch November 10, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YanVugenfirer YanVugenfirer YanVugenfirer approved these changes

@akihikodaki akihikodaki akihikodaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kostyanf14 @YanVugenfirer @akihikodaki