Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sort results in enforce-gatekeeper #309

Merged
merged 1 commit into from Jun 11, 2021
Merged

sort results in enforce-gatekeeper #309

merged 1 commit into from Jun 11, 2021

Conversation

mengqiy
Copy link
Contributor

@mengqiy mengqiy commented May 17, 2021

No description provided.

@google-cla google-cla bot added the cla: yes Google CLA OK label May 17, 2021
@mengqiy mengqiy requested a review from droot May 17, 2021 21:41
droot
droot approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@droot droot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for a quick turn around. minor nits.

functions/go/enforce-gatekeeper/validate.go Outdated Show resolved Hide resolved
functions/go/enforce-gatekeeper/validate.go Outdated Show resolved Hide resolved
functions/go/enforce-gatekeeper/validate.go Outdated Show resolved Hide resolved
@droot
Copy link
Contributor

droot commented May 18, 2021

Sorry for back and forth on this, but looks like (resource.ID, severity, file, field, message) will group messages for same resource together.

Just had an offline chat, file comparison is taking index into account as well, so messages from same resource will be grouped together, so we are good.

@mengqiy mengqiy mentioned this pull request Jun 8, 2021
Closed
@mengqiy
Copy link
Contributor Author

mengqiy commented Jun 8, 2021

Squashed commits and rebased on top of HEAD to resolve conflicts.

@mengqiy
Copy link
Contributor Author

mengqiy commented Jun 8, 2021

@Shell32-Natsu is looking for a function that can output structured results while exit code is still 0.

@mengqiy mengqiy requested a review from frankfarzan June 8, 2021 20:16
@mengqiy mengqiy mentioned this pull request Jun 8, 2021
Closed
@mengqiy mengqiy merged commit 8a5ee7e into GoogleContainerTools:master Jun 11, 2021
@mengqiy mengqiy deleted the sortresultsingk branch June 11, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot droot approved these changes

@frankfarzan frankfarzan frankfarzan approved these changes

@Shell32-Natsu Shell32-Natsu Awaiting requested review from Shell32-Natsu

Assignees
No one assigned
Labels
cla: yes Google CLA OK
Projects
None yet
Milestone
No milestone
3 participants
@mengqiy @droot @frankfarzan