Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK should provide a way to sort the structured results #2195

Closed
mengqiy opened this issue Jun 8, 2021 · 6 comments
Closed

SDK should provide a way to sort the structured results #2195

mengqiy opened this issue Jun 8, 2021 · 6 comments
Assignees
Labels
area/fn-sdk Typescript SDK good first issue Good for newcomers triaged Issue has been triaged by adding an `area/` label

Comments

@mengqiy
Copy link
Contributor

mengqiy commented Jun 8, 2021

Both Golang and TS SDK should provide the same way to sort the structured results

Ref: GoogleContainerTools/kpt-functions-catalog#309 (comment)

@mengqiy mengqiy added area/fn-sdk Typescript SDK triaged Issue has been triaged by adding an `area/` label labels Jun 8, 2021
@mengqiy mengqiy added this to the v1.0 m3 milestone Jun 8, 2021
@mengqiy mengqiy added this to To do in kpt kanban board via automation Jun 8, 2021
@mengqiy mengqiy self-assigned this Jun 8, 2021
@mikebz mikebz modified the milestones: v1.0 m3, v1.0 m4 Jun 9, 2021
@mikebz mikebz removed this from the v1.0 m4 milestone Jul 14, 2021
@morgante
Copy link
Contributor

morgante commented Dec 1, 2021

This code is now being continuously copied into multiple functions.

This SDK needs to be improved.

@mikebz When will this be prioritized?

@mengqiy mengqiy added the good first issue Good for newcomers label Dec 1, 2021
@mengqiy
Copy link
Contributor Author

mengqiy commented Dec 1, 2021

This code is now being continuously copied into multiple functions.

If this is happening, we should prioritize it.
@sdowell Can you please help with this? We can do it in kyaml first and then TS SDK.

@mengqiy
Copy link
Contributor Author

mengqiy commented Dec 1, 2021

@morgante
Copy link
Contributor

morgante commented Dec 1, 2021

Agreed with prioritizing it in kyaml first, since Go is where it's currently being copied (two examples so far).

sdowell added a commit to sdowell/kustomize that referenced this issue Dec 1, 2021
sdowell added a commit to sdowell/kustomize that referenced this issue Dec 1, 2021
sdowell added a commit to sdowell/kustomize that referenced this issue Dec 1, 2021
@sdowell sdowell self-assigned this Dec 29, 2021
@sdowell
Copy link
Contributor

sdowell commented Dec 29, 2021

This PR added support for sorting results via the Go SDK:
kubernetes-sigs/kustomize#4325

@mengqiy mengqiy removed their assignment Jan 7, 2022
@mengqiy
Copy link
Contributor Author

mengqiy commented Jan 7, 2022

TS SDK should provide similar sorting capability as kubernetes-sigs/kustomize#4325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/fn-sdk Typescript SDK good first issue Good for newcomers triaged Issue has been triaged by adding an `area/` label
Projects
None yet
Development

No branches or pull requests

4 participants