Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support a docker flavor meant to be used as base image for container-based CI jobs #2317

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

osher
Copy link

@osher osher commented Nov 13, 2022

Fixes #2325 in case of a bug fix, this should point to a bug and any other related issue(s)

Description

kaniko:debug is used a lot as a base image for CI job-containers.
However, unintuitively, it requires to use the kaniko:debug image, and to override the entrypoint, plus - it comes with just /busybox, and is therefore very limiting.

This MR is the result of my adventure, as documented here:
https://stackoverflow.com/questions/74402431/adding-build-tools-to-a-kaniko-image-for-gitlab-ci/74402843#74402843

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Examples of user facing changes:

  • The project will publish a new flavor of docker image - kaniko:ci, meant to be used more naturally as a base image for jobs on container-based CI setups like Gitlab-CI, and probably circle-ci and github-actions.

@google-cla
Copy link

google-cla bot commented Nov 13, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@osher
Copy link
Author

osher commented Nov 13, 2022

I know of one issue - the way I solved it in my project is for a concrete architecture.
If you could point the way on how to do it better - I will :)

keep up the great work.

@osher osher changed the title support a docker flavor meant to be used as basis for CI jobs support a docker flavor meant to be used as base image for container-based CI jobs Nov 13, 2022
@osher
Copy link
Author

osher commented Nov 16, 2022

Uh, sorry - I missed the thing about CLA. I did it now...

@osher
Copy link
Author

osher commented Nov 21, 2022

eh..? anybody home?

@osher
Copy link
Author

osher commented Nov 21, 2022

maybe I need to create an issue first - so I have...
#2325

@osher
Copy link
Author

osher commented Nov 29, 2022

im still here, when you're ready

@osher
Copy link
Author

osher commented Dec 12, 2022

@tejal29 @imjasonh - I mention you because I see you're contributors from google-cloud build...

Is the project dead?

@osher
Copy link
Author

osher commented Dec 28, 2022

🎶 I wont let the sun come down on me 🎶

@osher
Copy link
Author

osher commented Jan 11, 2023

😳

@osher
Copy link
Author

osher commented Jan 26, 2023

👀


FROM debian:bullseye-slim AS ci

#TBD: handle architecture, for now it's hardcoded :(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think this should be part of any kaniko ci container.
I also wanted to install bash but thats just a little bit hard for this image. Normally in CI you prepare everythin with other containers and then you mount your stuff inside kaniko to do the very rest.
Bash would however be nice to at least be able to write some scripts (not ins ash style...)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there is a way to be able to extend the kaniko image in a way programatically by other users, everybody has a different need. That would be nice...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support a docker flavor meant to be used as base image for container-based CI jobs
2 participants