Report initial CLS value when reportAllChanges is true #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #279 by ensuring that an initial CLS value of 0 is reported as soon as the page reaches FCP. For pages that don't set
reportAllChangesto true, they shouldn't notice any change; however, for pages that do setreportAllChangesto true, they may see additional reports come in.Note, I do not think this qualifies as a breaking change, because developers should not have been assuming a certain number of reports will be triggered on any particular page. It is possible this breaks some people's test pages, but it should not break anyone's real-world applications.