-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question about Interaction to Next Paint (INP) implementation #194
Comments
@Zizzamia hello! What do you think? |
Ciao @SuperOleg39, thank you for the ping and sorry for the late reply. Something I am been thinking for quite a while if it's time to make Perfume.js a superset of the Web Vitals package, by importing the package into Perfume and add some extra functionality on top of it. This will help stay always align with Google updates, and also keep the extra features that Perfume wants to experiment and offers. What's your thoughts on this? |
Hi! Thanks for the answer) I see only one problem about What do you think about |
@Zizzamia another reason to add "Report TTFB after a bfcache restore" and new "attribution build" looks like very important and useful. |
Yeah, I think Perfume.js is better suited to be a superset of web-vitals going forward. Going to make the change pretty soon. Just need to find a few hours to make the switch. Recently I got distracted on building a Performance library for React Native. But now I am back with more coding time on my hands. |
Alright, now Perfume.js is a super set of Web Vitals, starting from v8.0.0. Please, if you see anything that is not working let me know and I will take care of it. |
Thank you! Will try to integrate soon. |
Only one problem, now But I think than lazy loading solves this problem partially. |
Looks like First Paint is unsupported in |
About It is mean than we can send this metrics only when user leave/hide page twice, because if user will just close page after session, Maybe Upd. also ask question in |
The same behaviour with Total Blocking Time For now it is impossible to collect this metrics when user closing page, if batching is used https://github.com/GoogleChrome/web-vitals#batch-multiple-reports-together I will try to make a MR with optional |
@Zizzamia maybe we start with this changes - https://github.com/Zizzamia/perfume.js/pull/208/files About TBT, looks like it fired 10+ seconds after FID (expect 5 second because of https://zizzamia.github.io/perfume/#/total-blocking-time/) - so nothing to change here) |
You right! The fact Perfume does not handle on his on Change Visibility, it does introduce a regression. Which is not good, and makes the data quite unuseful. I am going to introduce back some fo the code related to Change Visibility that we used to have, and release a new version by the end of the year. Thank you for keep trying Perfume.js!!!! |
Will waiting for GoogleChrome/web-vitals#180 (comment) |
@SuperOleg39 your work in testing both libraries is just the best OSS Christmas present. Thank you man. I reverted some of the changes I initially made, and trying to recover the initial value of Perfume.js but still keeping the library as superset of web vitals. https://github.com/Zizzamia/perfume.js/releases/tag/v8.1.6 Let me know if looks better on your side, and love your testing in making Perfume.js better. I will make sure to prioritize your advice going forward. |
Thank you for all this work!) Test GoogleChrome/web-vitals#180 PR with Have only trouble with TBT - looks like this metric stop reported? |
Looks like TBT not reported, when:
|
Yeah the case you described is expected! Glad Perfume, now works well for you. |
Thanks for the explanation) |
Hello!
Do you have a plans for Interaction to Next Paint (INP) metric implementation?
Looks like implementation can be non-trivial, according to web-vitals package implementation.
I am interested in your opinion on this metric, as it will affect the size of the package badly, but it seems that this metric still have to start collecting in the future.
The text was updated successfully, but these errors were encountered: