Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tomli as a dependency in GMT Dev Tests #1401

Merged
merged 6 commits into from Aug 5, 2021
Merged

Add tomli as a dependency in GMT Dev Tests #1401

merged 6 commits into from Aug 5, 2021

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Jul 31, 2021

Description of proposed changes

Adding tomli to fix the GMT Dev Tests breakages reported in #1392. This is a temporary measure until pytest-cov releases a new version > 2.12.1 to incorporate the dependency fix in pytest-dev/pytest-cov#410.

While looking into #1392, I noticed that the pip install --pre ... command in ci_tests_dev.yaml doesn't seem to produce any output in the GitHub Actions log (see e.g. https://github.com/GenericMappingTools/pygmt/runs/3206665246?check_suite_focus=true#step:7:4). So are the pip packages actually being installed? Not sure if this is a bug introduced after #1105, so am investigating here. Edit: ok, using pip list at 0a8ab3d shows that the pip packages are indeed installed.

Fixes #1392

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@weiji14 weiji14 self-assigned this Jul 31, 2021
@weiji14 weiji14 changed the title WIP Debugging GMT dev tests pip install --pre step WIP Temporarily add toml as a dependency in GMT Dev Tests Jul 31, 2021
Need to use tomli instead of toml.
@weiji14 weiji14 changed the title WIP Temporarily add toml as a dependency in GMT Dev Tests WIP Temporarily add tomli as a dependency in GMT Dev Tests Jul 31, 2021
@weiji14 weiji14 added the maintenance Boring but important stuff for the core devs label Aug 1, 2021
@weiji14 weiji14 changed the title WIP Temporarily add tomli as a dependency in GMT Dev Tests Add tomli as a dependency in GMT Dev Tests Aug 5, 2021
@weiji14 weiji14 marked this pull request as ready for review August 5, 2021 00:23
@seisman seisman added this to the 0.4.1 milestone Aug 5, 2021
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think we should merge it before releasing v0.4.1.

@weiji14 weiji14 merged commit 1f9ab43 into main Aug 5, 2021
@weiji14 weiji14 deleted the fix-ci-dev-tests branch August 5, 2021 01:36
@weiji14 weiji14 added skip-changelog Skip adding Pull Request to changelog and removed skip-changelog Skip adding Pull Request to changelog labels Oct 3, 2021
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Adding tomli to fix the GMT Dev Tests breakages reported
in GenericMappingTools#1392. This is a temporary measure until `pytest-cov`
releases a new version > 2.12.1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI tests fails due to pytest-cov requiring toml instead of tomli
2 participants