Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tomli from GMT Tests and GMT Dev Tests workflows #2080

Merged
merged 1 commit into from Aug 24, 2022
Merged

Conversation

seisman
Copy link
Member

@seisman seisman commented Aug 23, 2022

Description of proposed changes

tomli was added as a CI dependency in #1564 and #1401 due to the issue #1392.

It seems now it's OK to remove it.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman marked this pull request as ready for review August 23, 2022 16:08
@seisman seisman added the maintenance Boring but important stuff for the core devs label Aug 24, 2022
@seisman seisman added this to the 0.8.0 milestone Aug 24, 2022
@seisman seisman requested a review from weiji14 August 24, 2022 02:52
@seisman seisman merged commit 2dc1f83 into main Aug 24, 2022
@seisman seisman deleted the remove-tomli branch August 24, 2022 03:36
@weiji14 weiji14 added the skip-changelog Skip adding Pull Request to changelog label Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants