Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily add back IE11 to our targets #42

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Temporarily add back IE11 to our targets #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a0f4dd
Force browserslist dedupe by using npm 8 overrides
pascalduez Jul 29, 2022
e6a5ee2
Add back IE11 temporarily to our targets
pascalduez Jul 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
# Change log

## [Unreleased]
### Fixed
* Temporarily add back IE11 to our targets.
In recent Browserslist versions the not dead query removes IE11 from our targets. This breaks our ES5 check on the legacy bundle.

## 5.8.1 - 2022-06-01
### Fixed
Expand Down
10 changes: 9 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,20 @@
* the class properties plugin.
* This is to avoid the `undefined` properties issue with old Flow props
* syntax: `class A { props: Props }`.
*
* 3. Temporary, see https://github.com/Gandi/babel-preset-gandi/pull/42
*/
module.exports = (context, options = {}) => {
let envOpts = Object.assign(
{
targets: {
browsers: ['last 2 versions', '> 1%', 'Firefox ESR', 'not dead'],
browsers: [
'last 2 versions',
'> 1%',
'not dead',
'Firefox ESR',
'IE 11', // 3
],
},
bugfixes: options.targets && options.targets.esmodules === true,
},
Expand Down