Temporarily add back IE11 to our targets #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalduez
force-pushed
the
hotfix/browserslist-ie11tig
branch
from
026c1d2
to
2f939d7
Compare
yanndinendal
approved these changes
Jul 29, 2022
- In recent Browserslist version the "not dead" query removes IE11. This breaks our ES5 check on the legacy bundle. Add it back temporarily, until we tackle the major Babel/targets etc revamp.
pascalduez
force-pushed
the
hotfix/browserslist-ie11tig
branch
from
2f939d7
to
e6a5ee2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In recent Browserslist version the
not deadquery removes IE11 from our targets.This breaks our ES5 check on the legacy bundle.
Add it back temporarily, until we tackle the major Babel/targets etc revamp.
To be able to test it, we need to dedupe the
browserlisttransitive dep.To be able to dedupe, we need
resolutionsoverrides.To be able to use
overrideswe need npm >= 8.3.How to review?
There are no changes in our snapshots, this means everything is back to normal :)